fix: money account selection on perps page

[jpuri]

Description

Fix money account selection on perps page

Changelog

CHANGELOG entry:

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/CONF-1577

Manual testing steps

NA

Screenshots/Recordings

NA

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Low Risk
Small UI branching change in confirmation pay-with row with expanded unit tests; no auth or payment execution changes.

Overview
Pay with row routing now treats controller PaymentOverride.MoneyAccount and flag-based money account default separately.

An explicit money account override always renders the money account row, including on the review step when isResultReady is true (e.g. perps deposit). The feature-flag default still shows the money account row only before results are ready; on review it falls back to the interactive token row unless the user explicitly chose money account.

Tests were updated to match and a case was added for flag-only default on review vs explicit override.

^{Reviewed by Cursor Bugbot for commit 957fd9e. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeConfirmations, SmokeMoney, SmokePerps, SmokePredictions, SmokeWalletPlatform
• Selected Performance tags: None (no tests recommended)
• Risk Level: medium
• AI Confidence: 88%

click to see 🤖 AI reasoning details

E2E Test Selection:
The PR changes the PayWithRow component logic in the confirmations area. The fix separates two behaviors:

1. Explicit PaymentOverride.MoneyAccount (always show Money Account row, regardless of isResultReady)
2. Flag-based default (only show Money Account row when results are NOT ready yet)

Previously, both cases were combined in one condition, causing the explicit override to incorrectly defer to the interactive row when isResultReady was true.

This change directly affects:

• SmokeConfirmations: The PayWithRow is a confirmation UI component used in transaction confirmation screens
• SmokeMoney: Money Account/Card deposit flows use this component for the "Pay With" selection
• SmokePerps: Perps deposit flows use custom-amount-info which includes PayWithRow; per tag description, SmokePerps also requires SmokeWalletPlatform and SmokeConfirmations
• SmokePredictions: Predictions deposit/withdrawal flows use custom-amount-info which includes PayWithRow; per tag description, SmokePredictions also requires SmokeWalletPlatform and SmokeConfirmations
• SmokeWalletPlatform: Required as a dependent tag for both SmokePerps and SmokePredictions (Trending section)

The change is a targeted logic fix with clear scope — it only affects the PayWithRow rendering decision, not the broader confirmation infrastructure.

Performance Test Selection:
The changes are limited to a UI logic fix in the PayWithRow component (a conditional rendering decision). This does not affect app launch, asset loading, account list rendering, onboarding, login, swaps, or any other performance-sensitive flow. No performance tests are warranted.

View GitHub Actions results

[jpuri]

Skipping sonar as its not working currently