Conversation
semble-grammars 0.1.1 is now on PyPI, so drop the local editable-path override and pin a real version instead. uv.lock still resolves against the local path for now; regenerating it needs semble-grammars to clear the 1-week exclude-newer window (it was only just published).
…ad-free The tri-state manual cache existed to memoize a fallible, network-based download call. semble_grammars.get_parser bundles all grammars at install time, so a plain functools.cache suffices, matching the pattern already used in chunking/core.py's _cached_get_parser.
0.1.2 adds the embeddedtemplate alias, batch/heex grammars, and zsh alias found while benchmarking this branch against tree-sitter-language-pack.
Adds an exclude-newer-package override for semble-grammars so uv.lock can resolve it immediately instead of waiting out the general 1-week recency guard, since we control its release cadence.
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Confidence Score: 5/5The PR appears safe to merge with no concrete changed-code failure identified. The new parser APIs preserve the existing fallback behavior, the installer handles unavailable JSON5 parsing, and the dependency replacement introduces no changed vulnerable dependency path. Reviews (1): Last reviewed commit: "Regenerate uv.lock against real semble-g..." | Re-trigger Greptile |
ALL_LANGUAGES is just the extension-to-language mapping table, so every language value reaching chunk_source already satisfied this check by construction. The real support check already happens one layer down: chunk() returns None when _cached_get_parser() fails for any reason, and chunk_source already falls back to line chunking in that case.
Per review: a fixed-date override needs manual bumping every time we release. semble-grammars is ours, so the recency guard's supply-chain rationale doesn't apply to it anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR swaps out tree-sitter-language-pack for https://github.com/MinishLab/semble-grammars. This means the binaries become ~8mb bigger, but we get: