🧪 Add test coverage for StateManager command fetching

[MnemOnicE]

🎯 What: Adds missing test coverage for StateManager.get_all_known_commands in commando/main.py. This method is responsible for merging the system's BEGINNER_GUIDE defaults with custom overrides.
📊 Coverage: The new test suite TestStateManager verifies the dictionary merging functionality by explicitly asserting:

• BEGINNER_GUIDE commands are correctly parsed.
• Custom commands from self.custom_guide are injected.
• Overlapping keys (where a custom guide shadows a BEGINNER_GUIDE definition) take correct precedence without data loss.
  ✨ Result: Improved state initialization logic coverage and confidence around custom guide loading processes. Tested with 100% pass rate in standard test matrix locally.

---

PR created automatically by Jules for task 3725303791132763521 started by @MnemOnicE

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Warning

Review limit reached

@MnemOnicE, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 43 minutes and 5 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 4dd7e91d-f6d6-4b2e-b83a-85e1e740d5d5

📥 Commits

Reviewing files that changed from the base of the PR and between 796bb7c and c1d94cd.

📒 Files selected for processing (1)

• tests/test_main.py

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch jules-3725303791132763521-3667eed9

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Code Review

This pull request formats string literals in existing tests, improves readability with blank lines, and adds a new test class TestStateManager to verify command merging in StateManager.get_all_known_commands. The review feedback recommends configuring the patched load_json mock in the new test to return its default value argument, ensuring that other state attributes of StateManager are initialized with their correct default types rather than fragile MagicMock instances.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

When StateManager is instantiated, its __init__ method calls load_json multiple times to initialize state attributes like session_history, probe_blacklist, and pending_imports.

Because mock_load_json is patched but not configured, it returns a default MagicMock object for each call. This means these attributes will be initialized as MagicMock instances instead of their expected types (dict or list). While this test only asserts behavior on custom_guide (which is manually overridden), leaving other state attributes as MagicMock objects is fragile and can cause unexpected behavior if the class implementation changes.

Configuring mock_load_json.side_effect to return the default_val argument ensures that all state attributes are initialized with their correct, empty default types in a clean and robust way.

    def test_get_all_known_commands(self, mock_load_json):
        from commando.main import StateManager, BEGINNER_GUIDE

        # Configure mock to return the default value passed to load_json
        mock_load_json.side_effect = lambda filepath, default_val: default_val

        # Instantiate StateManager
        sm = StateManager()

[MnemOnicE]

@jules tests/test_main.py
Comment on lines +159 to +163
def test_get_all_known_commands(self, mock_load_json):
from commando.main import StateManager, BEGINNER_GUIDE

    # Instantiate StateManager
    sm = StateManager()

gemini-code-assist Bot
3 minutes ago
Contributor
medium

When StateManager is instantiated, its init method calls load_json multiple times to initialize state attributes like session_history, probe_blacklist, and pending_imports.

Because mock_load_json is patched but not configured, it returns a default MagicMock object for each call. This means these attributes will be initialized as MagicMock instances instead of their expected types (dict or list). While this test only asserts behavior on custom_guide (which is manually overridden), leaving other state attributes as MagicMock objects is fragile and can cause unexpected behavior if the class implementation changes.

Configuring mock_load_json.side_effect to return the default_val argument ensures that all state attributes are initialized with their correct, empty default types in a clean and robust way.

def test_get_all_known_commands(self, mock_load_json):
    from commando.main import StateManager, BEGINNER_GUIDE

    # Configure mock to return the default value passed to load_json
    mock_load_json.side_effect = lambda filepath, default_val: default_val

    # Instantiate StateManager
    sm = StateManager() 

[google-labs-jules]

@jules tests/test_main.py
Comment on lines +159 to +163
def test_get_all_known_commands(self, mock_load_json):
from commando.main import StateManager, BEGINNER_GUIDE

    # Instantiate StateManager
    sm = StateManager()

gemini-code-assist Bot
3 minutes ago
Contributor
medium

When StateManager is instantiated, its init method calls load_json multiple times to initialize state attributes like session_history, probe_blacklist, and pending_imports.

Because mock_load_json is patched but not configured, it returns a default MagicMock object for each call. This means these attributes will be initialized as MagicMock instances instead of their expected types (dict or list). While this test only asserts behavior on custom_guide (which is manually overridden), leaving other state attributes as MagicMock objects is fragile and can cause unexpected behavior if the class implementation changes.

Configuring mock_load_json.side_effect to return the default_val argument ensures that all state attributes are initialized with their correct, empty default types in a clean and robust way.

def test_get_all_known_commands(self, mock_load_json):
    from commando.main import StateManager, BEGINNER_GUIDE

    # Configure mock to return the default value passed to load_json
    mock_load_json.side_effect = lambda filepath, default_val: default_val

    # Instantiate StateManager
    sm = StateManager() 

Good catch! Leaving other attributes as MagicMock instances is definitely fragile. I've updated the test to set mock_load_json.side_effect = lambda filepath, default_val: default_val so that they correctly default to empty dictionaries and lists as intended.