🔒 Replace unsafe preexec_fn with start_new_session in audit.py

[MnemOnicE]

🎯 What:
Replaced preexec_fn=os.setsid with start_new_session=True in subprocess.Popen within commando/core/audit.py.

⚠️ Risk:
Using preexec_fn in Python can lead to severe security and stability issues in multi-threaded applications. Specifically, if a thread holds a lock or forks concurrently, running an arbitrary callable via preexec_fn just before exec() can cause the child process to deadlock, potentially leading to denial of service or unexpected program crashes. This is a well-documented risk in the Python standard library.

🛡️ Solution:
Python 3.2+ introduced the start_new_session parameter to subprocess.Popen specifically to handle the common use case of running os.setsid safely. By switching to start_new_session=True, the child process continues to start in a new process group without risking deadlocks from concurrent threading operations, ensuring safe and reliable dynamic auditing (e.g., via strace).

---

PR created automatically by Jules for task 7263063674757777343 started by @MnemOnicE

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Warning

Review limit reached

@MnemOnicE, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 26 minutes and 44 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 084ac57c-a31a-463d-970c-a1f19b62e84a

📥 Commits

Reviewing files that changed from the base of the PR and between d560805 and 3144b79.

📒 Files selected for processing (2)

• PR_DESCRIPTION.md
• commando/core/audit.py

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch jules-7263063674757777343-60f584f5

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Code Review

This pull request replaces the unsafe preexec_fn=os.setsid with start_new_session=True in subprocess.Popen within commando/core/audit.py to prevent potential deadlocks in multi-threaded environments, and applies minor formatting to an input prompt. The reviewer pointed out that PR_DESCRIPTION.md was accidentally committed to the repository and should be deleted.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

It appears that PR_DESCRIPTION.md was accidentally committed to the repository. This file contains the pull request description, which should only be submitted as the PR body on GitHub/GitLab rather than being tracked in version control. Please delete this file from the repository.

[MnemOnicE]

@jules PR_DESCRIPTION.md
Comment on lines +1 to +10

🔒 Security Fix: Replace unsafe preexec_fn with start_new_session

🎯 What:
Replaced preexec_fn=os.setsid with start_new_session=True in subprocess.Popen within commando/core/audit.py.

⚠️ Risk:
Using preexec_fn in Python can lead to severe security and stability issues in multi-threaded applications. Specifically, if a thread holds a lock or forks concurrently, running an arbitrary callable via preexec_fn just before exec() can cause the child process to deadlock, potentially leading to denial of service or unexpected program crashes. This is a well-documented risk in the Python standard library.

🛡️ Solution:
Python 3.2+ introduced the start_new_session parameter to subprocess.Popen specifically to handle the common use case of running os.setsid safely. By switching to start_new_session=True, the child process continues to start in a new process group without risking deadlocks from concurrent threading operations, ensuring safe and reliable dynamic auditing (e.g., via strace).
@gemini-code-assist
gemini-code-assist Bot
yesterday
Contributor
medium

It appears that PR_DESCRIPTION.md was accidentally committed to the repository. This file contains the pull request description, which should only be submitted as the PR body on GitHub/GitLab rather than being tracked in version control. Please delete this file from the repository.

[google-labs-jules]

@jules PR_DESCRIPTION.md
Comment on lines +1 to +10

🔒 Security Fix: Replace unsafe preexec_fn with start_new_session

🎯 What:
Replaced preexec_fn=os.setsid with start_new_session=True in subprocess.Popen within commando/core/audit.py.

⚠️ Risk:
Using preexec_fn in Python can lead to severe security and stability issues in multi-threaded applications. Specifically, if a thread holds a lock or forks concurrently, running an arbitrary callable via preexec_fn just before exec() can cause the child process to deadlock, potentially leading to denial of service or unexpected program crashes. This is a well-documented risk in the Python standard library.

🛡️ Solution:
Python 3.2+ introduced the start_new_session parameter to subprocess.Popen specifically to handle the common use case of running os.setsid safely. By switching to start_new_session=True, the child process continues to start in a new process group without risking deadlocks from concurrent threading operations, ensuring safe and reliable dynamic auditing (e.g., via strace).
@gemini-code-assist
gemini-code-assist Bot
yesterday
Contributor
medium

It appears that PR_DESCRIPTION.md was accidentally committed to the repository. This file contains the pull request description, which should only be submitted as the PR body on GitHub/GitLab rather than being tracked in version control. Please delete this file from the repository.

Ah, you're right. I've removed PR_DESCRIPTION.md from the repository.