Support ArraysOfArrays v1 - #13
Merged
AntonOresten merged 1 commit intoAug 27, 2026
Merged
Conversation
Widen the ArraysOfArrays compat entry to "0.6, 1". The package only uses `VectorOfArrays(nested)` and `collect`s elements on `getindex`, both unchanged in v1, so no source changes are needed. Created by generative AI.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
=======================================
Coverage 95.55% 95.55%
=======================================
Files 1 1
Lines 45 45
=======================================
Hits 43 43
Misses 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I maintain ArraysOfArrays.jl, which just had its v1.0 release, and I'm going through the downstream packages to offer compatibility PRs where they're needed — this is one of them.
What changed in ArraysOfArrays v1
The element type of
VectorOfArraysand friends is now a view rather than a copy, several old constructors are deprecated, andnestedviewis deprecated in favour of the array-of-arrays constructors.What this PR changes
Just the compat entry:
No source changes are needed. MergedArrays only touches two parts of the ArraysOfArrays API, and neither is affected by the v1 changes:
ArraysOfArrays.VectorOfArrays(vec(arrays)), the nested-arrays constructor, which behaves the same in v1.Base.getindex(array::MergedArrayOfArrays, i::Integer) = collect(array.storage[i]), whichcollects the element — so the elements-are-now-views change is invisible here, andMergedArrayOfArrayskeeps returning plainArrays exactly as before.Testing
I ran the test suite against both majors on Julia 1.12, with
--depwarn=yes:Test Summary: MergedArrays.jl | Pass 27 | Total 27— passedTest Summary: MergedArrays.jl | Pass 27 | Total 27— passedNo deprecation warnings in either configuration.
One note, and a small request
This repo's CompatHelper workflow is currently in the
disabled_inactivitystate, so no automated compat bump would have arrived for the v1 release — hence the manual PR.If this looks good to you, would you be willing to tag a patch release (0.3.1) once it's merged? The registry resolves compat from released versions, so without a tag MergedArrays would still hold users back to ArraysOfArrays 0.6. Happy to answer any questions about the v1 changes if something does come up.
🤖 Generated with Claude Code