Skip to content

Docker: Fix condition of recording by session capability se:recordVideo - #42

Open
VietND96 wants to merge 1 commit into
trunkfrom
claude/selenium-video-recording-condition-hHeg5
Open

Docker: Fix condition of recording by session capability se:recordVideo #42
VietND96 wants to merge 1 commit into
trunkfrom
claude/selenium-video-recording-condition-hHeg5

Conversation

@VietND96

@VietND96 VietND96 commented Jun 5, 2026

Copy link
Copy Markdown
Member

Description

This change ensures that the SE_RECORD_VIDEO environment variable is consistently honored across both event-driven and shell-mode video recording. Previously, when the se:recordVideo capability was absent from a session, the code would default to true regardless of the SE_RECORD_VIDEO environment setting.

The fix implements a fallback mechanism in both video_service.py and video_graphQLQuery.py:

  • When se:recordVideo capability is present on the session, it takes precedence
  • When the capability is absent (None), the code now falls back to the SE_RECORD_VIDEO environment variable (defaulting to "true" if not set)
  • Improved handling of different value types (string, boolean, etc.) with explicit type conversion

This brings consistency with the shell-mode helper (video_nodeQuery.py) and ensures SE_RECORD_VIDEO=false is respected in all recording modes.

Motivation and Context

Users setting SE_RECORD_VIDEO=false to disable video recording would find it ignored when sessions didn't explicitly include the se:recordVideo capability. This inconsistency between event-driven and shell-mode recording behavior could lead to unexpected video files being generated.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing document
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

https://claude.ai/code/session_01GS9nWJdMQedyVKojiSEkbh

Signed-off-by: Viet Nguyen Duc <viet.dnguyen@katalon.com>
@VietND96
VietND96 force-pushed the claude/selenium-video-recording-condition-hHeg5 branch from 8e407f5 to 96dac3e Compare June 8, 2026 02:32
@VietND96 VietND96 changed the title Honor SE_RECORD_VIDEO env var when capability is absent Docker: Fix condition of recording by session capability se:recordVideo Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant