Docker: Fix condition of recording by session capability se:recordVideo - #42
Open
VietND96 wants to merge 1 commit into
Open
Docker: Fix condition of recording by session capability se:recordVideo #42VietND96 wants to merge 1 commit into
VietND96 wants to merge 1 commit into
Conversation
Signed-off-by: Viet Nguyen Duc <viet.dnguyen@katalon.com>
VietND96
force-pushed
the
claude/selenium-video-recording-condition-hHeg5
branch
from
June 8, 2026 02:32
8e407f5 to
96dac3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change ensures that the
SE_RECORD_VIDEOenvironment variable is consistently honored across both event-driven and shell-mode video recording. Previously, when these:recordVideocapability was absent from a session, the code would default totrueregardless of theSE_RECORD_VIDEOenvironment setting.The fix implements a fallback mechanism in both
video_service.pyandvideo_graphQLQuery.py:se:recordVideocapability is present on the session, it takes precedenceNone), the code now falls back to theSE_RECORD_VIDEOenvironment variable (defaulting to"true"if not set)This brings consistency with the shell-mode helper (
video_nodeQuery.py) and ensuresSE_RECORD_VIDEO=falseis respected in all recording modes.Motivation and Context
Users setting
SE_RECORD_VIDEO=falseto disable video recording would find it ignored when sessions didn't explicitly include these:recordVideocapability. This inconsistency between event-driven and shell-mode recording behavior could lead to unexpected video files being generated.Types of changes
Checklist
https://claude.ai/code/session_01GS9nWJdMQedyVKojiSEkbh