Clear error when injections references an unknown inline YARA rule - #2238
Draft
kilanassah wants to merge 1 commit into
Draft
Clear error when injections references an unknown inline YARA rule#2238kilanassah wants to merge 1 commit into
kilanassah wants to merge 1 commit into
Conversation
…n inline rule `_load_rules` filtered `yara_rules` by intersection with the requested `rule_names` but then re-indexed the dict with *every* requested name, so a name present in `injections` but absent from the inline `yara_rules` raised a bare `KeyError` with no context. Validate the requested names against the available inline rules up front and raise a descriptive `ValueError` naming the missing rule(s) and listing the available ones — matching the existing error convention in the `yara_path` branch. Behaviour is unchanged when all names are present. Adds a CPU-only regression test. Fixes NVIDIA-NeMo#2170 Signed-off-by: operator <131236286+kilanassah@users.noreply.github.com>
github-actions
Bot
added
size: S
status: needs triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2170.
Raise a descriptive
ValueErrorwhen an inline YARA rule referenced byinjectionsisn't present inyara_rules.Previously the missing rule surfaced as a bare
KeyError, which made the misconfiguration hard to diagnose.Adds a regression test for the missing-rule case.