TEST: Reduce redundant numerical test matrices - #24019
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe changes revise covariance and correlation test inputs to use shared paired cases and simplify masked binary test parameterization by removing numeric type variation. ChangesCovariance and correlation test data
Masked binary test parameters
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change reduces redundant covariance, correlation, and masked-binary test parameterization while preserving the represented behavior cases. No current merge-blocking risk is identified. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
| @pytest.mark.parametrize( | ||
| "data1", | ||
| [ | ||
| COV_CORR_DATA_PAIRS = [ |
There was a problem hiding this comment.
optional: This could also just be a parametrized, module scope fixture
|
/merge |
Addresses small review follow-ups from these merged Python test optimization PRs: - [#24018](#24018) - [#24019](#24019) - [#24020](#24020) - [#24029](#24029) - [#24032](#24032) - [#24033](#24033) This is a test-only follow-up that incorporates the agreed small cleanup suggestions without changing the intended test coverage. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Matthew Roeschke (https://github.com/mroeschke) URL: #24098
Description
Replace covariance/correlation’s redundant operand Cartesian product with nine explicit representative pairs, and remove an unused parameter from one masked-binary execution test.
Coverage accounting
Checklist