Decouple host drivers and shutdown - #2702
Open
Arc676 wants to merge 1 commit into
Open
Conversation
Arc676
requested review from
cdesiniotis,
karthikvetrivel,
rahulait,
rajathagasthya,
shivamerla and
tariq1890
as code owners
July 31, 2026 07:32
Don't assume that systemd clients must be shut down if the host has drivers Signed-off-by: Alessandro Vinciguerra <alessandro.vinciguerra@postfinance.ch>
Arc676
force-pushed
the
decouple-driver-host-shutdown
branch
from
July 31, 2026 07:34
ac78991 to
5aa78c1
Compare
|
Thanks for the contribution. We will review this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Decouple the host shutdown flag from the host driver flag. This adds support for systems that have the NVIDIA drivers installed locally but do not run
systemd, for example Talos. The user can install the drivers via system extension but setWITH_SHUTDOWN_HOST_GPU_CLIENTS=falsevia Helm values to disable all code paths in the MIG manager that depend onsystemd.This requires a change to the chart because the entrypoint for the MIG manager is managed by the operator and the variable is set here. The user can't override the value or modify the
ConfigMap; the former approach would have no effect and the latter approach would be immediately reverted by the operator.See discussions in NVIDIA/mig-parted#382 and the parent issue NVIDIA/mig-parted#356.
Checklist
No secrets, sensitive information, or unrelated changes
Lint checks passing (
make lint)Generated assets in-sync (
make validate-generated-assets)Go mod artifacts in-sync (
make validate-modules)Test cases are added for new code paths
Testing
Tested manually on a Kubernetes cluster running the aforementioned patch.