Update node-labeling-controller to watch for singleton CR create/update events - #2704
Merged
Merged
Conversation
cdesiniotis
marked this pull request as ready for review
July 31, 2026 18:11
cdesiniotis
requested review from
karthikvetrivel,
rahulait,
rajathagasthya,
shivamerla and
tariq1890
as code owners
July 31, 2026 18:11
…te events This fixes an issue where the operator starts running before a ClusterPolicy or GPUCluster CR has been created. The node-labeling-controller's first reconciliation will not add any labels to GPU nodes. It won't reconcile again until after a singleton CR has been created and updated at least once. The controller should reconcile, and label nodes, as soon as one of these CRs is created. Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
cdesiniotis
force-pushed
the
watch-create-events-in-nlc
branch
from
July 31, 2026 18:25
e78d5e1 to
7b8dcad
Compare
tariq1890
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue where the operator starts running before a ClusterPolicy or GPUCluster CR has been created. The node-labeling-controller's first reconciliation will not add any labels to GPU nodes. It won't reconcile again until after a singleton CR has been created and updated at least once. The controller should reconcile, and label nodes, as soon as one of these CRs is created.
Checklist
make lint)make validate-generated-assets)make validate-modules)Testing
Manually tested on single node GPU cluster.