fix(datadog): Encode metadata error value before embedding in error field - #174
Open
doughsay wants to merge 1 commit into
Open
fix(datadog): Encode metadata error value before embedding in error field#174doughsay wants to merge 1 commit into
doughsay wants to merge 1 commit into
Conversation
…ield
format_error/4 embedded the raw metadata :error value into the log line,
bypassing RedactorEncoder. A non-JSON-encodable term (e.g. an {:error,
reason} tuple) then crashed the encoder, and because maybe_merge is
left-biased the encoded copy of the metadata could not overwrite it. The
formatter crash surfaces as "FORMATTER CRASH: ..." fallback lines and the
original log event is lost entirely.
Run the value through encode/2 (which also applies redactors), matching
how every other part of the line is built.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
format_error/4embeds the raw metadata:errorvalue into the log line, bypassingRedactorEncoder. A non-JSON-encodable term (e.g. an{:error, reason}tuple) then crashes the encoder.This fix runs the value through
encode/2(which also applies redactors), matching how every other part of the line is built.