fix: KeyPerf collector should not export partner volumes - #4419
Open
rahulguptajss wants to merge 4 commits into
Open
fix: KeyPerf collector should not export partner volumes#4419rahulguptajss wants to merge 4 commits into
rahulguptajss wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the KeyPerf volume collector to avoid exporting metrics for MetroCluster partner volumes by incorporating volume state into collection and using it to mark instances as non-exportable unless they are online.
Changes:
- Added
stateas a collected label in KeyPerf volume YAML configs (and corresponding testdata config). - Updated the KeyPerf volume plugin to set
IsExportable=falsefor volumes under SVMs ending in-mcunlessstate == "online". - Added a unit test covering MetroCluster
-mcvolumes for online/offline/missing-state behavior.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| conf/keyperf/9.15.0/volume.yaml | Collect state for volume instances/endpoints so the plugin can filter exportability. |
| conf/keyperf/9.11.1/volume.yaml | Same state label addition for the 9.11.1 KeyPerf config variant. |
| conf/keyperf/9.10.0/volume.yaml | Same state label addition for the 9.10.0 KeyPerf config variant. |
| cmd/collectors/keyperf/testdata/conf/keyperf/9.15.0/volume.yaml | Updates test config to include state so unit tests reflect real collection. |
| cmd/collectors/keyperf/plugins/volume/volume.go | Implements exportability filtering for -mc SVM volumes based on state. |
| cmd/collectors/keyperf/plugins/volume/volume_test.go | Adds coverage ensuring -mc volumes are only exportable when online (and missing state is not exportable). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.