Skip to content

[18.0][MIG] website_geoengine: Migration to 18.0 - #474

Open
LINTOANTONY007 wants to merge 8 commits into
OCA:18.0from
LINTOANTONY007:18.0-mig-website_geoengine
Open

[18.0][MIG] website_geoengine: Migration to 18.0#474
LINTOANTONY007 wants to merge 8 commits into
OCA:18.0from
LINTOANTONY007:18.0-mig-website_geoengine

Conversation

@LINTOANTONY007

@LINTOANTONY007 LINTOANTONY007 commented Aug 6, 2026

Copy link
Copy Markdown

This PR is depended on OCA/partner-contact#2417
Once this PR is merged ,

  1. website_geoengine will be migrated to 18.0
  2. Field opening_hours in res.partner model is moved to partner-contact/partner_store module, as opening_hours is a store related property field. So I think it must be in module partner_store of partner-contact repo.

Please Refer : OCA/partner-contact#2417

  1. Added some Test Cases.

@OCA-git-bot OCA-git-bot added mod:website_geoengine Module website_geoengine series:18.0 labels Aug 6, 2026
@LINTOANTONY007
LINTOANTONY007 force-pushed the 18.0-mig-website_geoengine branch 3 times, most recently from 17dc15a to db1dd12 Compare August 6, 2026 09:19
@LINTOANTONY007
LINTOANTONY007 marked this pull request as draft August 6, 2026 09:19
@LINTOANTONY007
LINTOANTONY007 marked this pull request as ready for review August 6, 2026 09:49
@LINTOANTONY007

LINTOANTONY007 commented Aug 6, 2026

Copy link
Copy Markdown
Author

@mymage , Can you please review this PR ?

@LINTOANTONY007

Copy link
Copy Markdown
Author

@tarteo , Can you review this PR?

tags = kw.get("tags", {})
lang = kw.get("lang", "en_US")
maxResults = kw.get("maxResults", "200")
max_results = kw.get("maxResults", "200")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should maxResults key also be snake case, or is this somehow required?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we need to make maxResults key snake case , then I need to make change in other module (Refer the line mentioned below). It is doable , simply because of this I just neglected it. If that is the case I can do it.

 const args = {
            tags: tags,
            lang: this.lang,
            maxResults: this.maxResults,
        };

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarteo , Done ! , changed key to snake case.

Comment thread website_geoengine/controllers/__init__.py Outdated
@LINTOANTONY007
LINTOANTONY007 force-pushed the 18.0-mig-website_geoengine branch from db1dd12 to 6e51d54 Compare September 1, 2026 12:58
@LINTOANTONY007
LINTOANTONY007 force-pushed the 18.0-mig-website_geoengine branch from 6e51d54 to 7adc0b2 Compare September 3, 2026 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:website_geoengine Module website_geoengine series:18.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants