Skip to content

GENSAL Machine Model#385

Draft
lukelowry wants to merge 2 commits intodevelopfrom
lukel/gensal-dev
Draft

GENSAL Machine Model#385
lukelowry wants to merge 2 commits intodevelopfrom
lukel/gensal-dev

Conversation

@lukelowry
Copy link
Copy Markdown
Collaborator

@lukelowry lukelowry commented Apr 30, 2026

Description

Implementation and documentation for GENSAL model.

Proposed changes

  • Saturation model adjustments
  • GENSAL Documentation
  • GENSAL Implementation
  • GENSAL Tests

Checklist

  • All tests pass (except that one known error in PowerElectronics)
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • I have updated CHANGELOG.md to reflect the changes in this PR. If this is a minor PR that is part of a larger fix already included in the file, state so.

Further comments

Some consistency improvements with GENROU and parameter edge cases

@lukelowry lukelowry requested a review from abirchfield April 30, 2026 15:57
Copy link
Copy Markdown
Collaborator

@abirchfield abirchfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to do. It would be better if there were a 2-bus case matching PowerWorld to make sure it's right.

@lukelowry
Copy link
Copy Markdown
Collaborator Author

This is good to do. It would be better if there were a 2-bus case matching PowerWorld to make sure it's right.

I will add that to this PR because I agree here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants