Refactor PhasorDynamics hierarchy to consolidate duplicate code#386
Draft
PhilipFackler wants to merge 1 commit intodevelopfrom
Draft
Refactor PhasorDynamics hierarchy to consolidate duplicate code#386PhilipFackler wants to merge 1 commit intodevelopfrom
PhasorDynamics hierarchy to consolidate duplicate code#386PhilipFackler wants to merge 1 commit intodevelopfrom
Conversation
e65a100 to
d0bcf0a
Compare
d0bcf0a to
e2d066a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SystemModelProposed changes
This inserts a class (
ConnectedElement) into the phasor dynamics hierarchy which will manage signal node ports and monitors. This new class takes its child class as its template parameter and uses traits to get more detailed type information (for variable enums, etc...) and also to customize the inheritance graph. Each leaf node device type must inherit fromConnectedElementTraitswith itself as the template argument and define a customization ofConnectedElementTraitswith the appropriate type information. TheInterfaceTmember determines which interface is inherited. For example...For
BusAnd for
BranchChecklist
-Wall -Wpedantic -Wconversion -Wextra.This PR changes the style guidelines with respect to template parameters and type aliases.
This PR was developed on top of Refactoring phasor dynamics constituent models #381 and will need to be rebased.
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining
why you chose the solution you did and what alternatives you considered, etc...