Support latest changes for tx filtering hashing scheme#194
Support latest changes for tx filtering hashing scheme#194MishkaRogachev wants to merge 3 commits into
Conversation
MishkaRogachev
force-pushed
the
script-that-generates-censored-hashed-addresses-file
branch
from
61b6a33 to
928b79a
Compare
diegoximenes
left a comment
diegoximenes
left a comment
There was a problem hiding this comment.
I changed base branch to master.
Those changes weren't already introduced to master by recent PRs?
|
Well, I pushed "Fix with Copilot" green button and it messed up the whole PR. @diegoximenes build was failing due to prysm version. I'm not sure if I should touch it in this PR. To make the CI pass I hardcoded |
MishkaRogachev
changed the title
diegoximenes
left a comment
diegoximenes
left a comment
There was a problem hiding this comment.
I am still not convinced this PR should exist the way it is.
Most of those changes are already on master branch.
This PR is targeting release branch.
The release and master branch are out of sync, but this is another issue.
Besides that, initTxFilteringMinioCommand is using sha256-rawbytesinput, while computeAddressHash is based on sha256-stringinput.
It is fine to create a PR to change nitro-testnode to use sha256-rawbytesinput, but it needs to target master branch.
I agree; the changes will be minimal if the release/master issue is resolved |
Part of NIT-4912