feat: add log message color configuration#108
Open
Wafffle77 wants to merge 3 commits into
Open
Conversation
Signed-off-by: Ethan Clark <ethan.clark@trojans.dsu.edu>
Signed-off-by: Ethan Clark <ethan.clark@trojans.dsu.edu>
Signed-off-by: Ethan Clark <ethan.clark@trojans.dsu.edu>
synackd
requested changes
Jul 1, 2026
synackd
left a comment
Collaborator
There was a problem hiding this comment.
I tested this and it works well.
However, there is a missing piece that is required for config merging to work correctly. For instance, if I:
# Set value in user config
ochami config set log.color on
I can see it get changed in the user config:
$ ochami config show log.color --user
on
But the merged config uses the default value:
$ ./ochami config show log.color
auto
To fix this, we'll have to add a case for this config value in the custom config unmarshaller. There is already code there for timeout (case statement, default value setting) that can serve as a reference.
Collaborator
|
I adjusted the title of this PR to follow Conventional Commit format for the future squash merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Thank you for your contribution! Please ensure the following before submitting:
Checklist
make test(or equivalent) locally and all tests passgit commit -s) with my real name and email<filename>.licensesidecarLICENSES/directoryDescription
Adds a
--log-coloroption for controlling colored log output. In addition to "on" and "off", "auto" (the default) will detect whether or not stderr is a terminal and act accordingly.Type of Change
For more info, see Contributing Guidelines.