chore: upgrade Manage to 9.7.2, drop secret from oidc10_rp required#92
Merged
Conversation
sp-dashboard PRs SURFnet/sp-dashboard#1461 and SURFnet/sp-dashboard#1466 fix public OIDC client handling by omitting the secret field entirely instead of sending null (NPE in SecretHook) or "" (fails min-length validation). This required Manage to no longer mandate the secret field for oidc10_rp entities when isPublicClient is true. The upstream Manage schema was updated post-9.7.2 to remove "secret" from the metaDataFields required array in oidc10_rp.schema.json. Confirmed against manage.test2.surfconext.nl: POST without secret field succeeds for public clients. Verified locally after this upgrade. Changes: - docker-compose.yml: bump manage-server and manage-gui 9.6.2 → 9.7.2 - application.yml: add push.stepup.* and product.jira_* required by 9.7.2 - oidc10_rp.schema.json: remove "secret" from required array
johanib
approved these changes
May 28, 2026
Contributor
johanib
left a comment
johanib
left a comment
There was a problem hiding this comment.
lgtm
Curious: Where does the stepup config in application.yml come from and why is it needed?
Contributor
Author
I had the same question. Its for manage. Manage needs these params set in the newer version even when its disabled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sp-dashboard PRs SURFnet/sp-dashboard#1461 and SURFnet/sp-dashboard#1466 fix public OIDC client handling by omitting the secret field entirely instead of sending null (NPE in SecretHook) or "" (fails min-length validation). This required Manage to no longer mandate the secret field for oidc10_rp entities when isPublicClient is true.
The upstream Manage schema was updated post-9.7.2 to remove "secret" from the metaDataFields required array in oidc10_rp.schema.json. Confirmed against manage.test2.surfconext.nl: POST without secret field succeeds for public clients. Verified locally after this upgrade.
Changes: