Filter the artifact run's result file - #359
Merged
Merged
Conversation
`simulate(variableFilter=…, resimulateExecutable=…)` keeps only `simflags`: the experiment arguments reach a model through the build, and a resimulate does not build. For the C lanes that is invisible, since the executable reads the filter from the `_init.xml` its own `buildModel` wrote, but a wasm artifact comes from `buildModelFMU`, which has no `variableFilter` argument. Every wasm-jit runner has therefore been writing every variable the model has. `artifactCmd` already passes the rest of the experiment as simflags for this same reason; `-variableFilter` was the one it missed. Measured on the MSL 4.1.0 QuasiStatic FundamentalWave `IMC_Conveyor`, whose comparisonSignals.txt names three variables: | | no filter | -variableFilter | | ------------------------------- | ------------- | --------------- | | result file | 1162 MB, 2857 | 4.97 MB, 3 | | timeSimulation | 8.81 s | 7.50 s | | verification, 500-row reference | 1.2-2.0 s | 0.42 s | | verification, peak RSS | 2.34 GB | 71 MB | Over the 10801 models both lanes verified in the latest run, master's verification column sums to 788 s and wasm-jit's to 2216 s; the tail is the Buildings EnergyPlus and Borefields models and the MSL machines examples, which is exactly where the unfiltered files are widest. Assisted-by: Claude Opus 5 (1M context)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
simulate(variableFilter=…, resimulateExecutable=…)keeps onlysimflags: the experiment arguments reach a model through the build, and a resimulate does not build. For the C lanes that is invisible, since the executable reads the filter from the_init.xmlits ownbuildModelwrote, but a wasm artifact comes frombuildModelFMU, which has novariableFilterargument. Every wasm-jit runner has therefore been writing every variable the model has.artifactCmdalready passes the rest of the experiment as simflags for this same reason;-variableFilterwas the one it missed.Measured on the MSL 4.1.0 QuasiStatic FundamentalWave
IMC_Conveyor, whose comparisonSignals.txt names three variables:Over the 10801 models both lanes verified in the latest run, master's verification column sums to 788 s and wasm-jit's to 2216 s; the tail is the Buildings EnergyPlus and Borefields models and the MSL machines examples, which is exactly where the unfiltered files are widest.
Assisted-by: Claude Opus 5 (1M context)