Simplifications to computeRadianceRecurse() function#22
Open
jlanz wants to merge 1 commit into
Open
Conversation
* Add dedicated version of CRR() for ray depth 0
* Remove tests for ray depth 0
* Remove redundant params from CRR1()
* Minor simplifications
* Further minor simplifications
* Eliminate ignoreVolumes and hitVolume params from CRR1()
* Eliminate IndirectRadianceType flags and make CRR() funcs return type be void
* Tidy up logic for indirectFlags and doIndirect
* Make CRR1() return the radiance rather than pass it as a reference
* Reduce processing for ref{le|ra}cted cryptomatte in CRR1()
* Remove redundant variable & corresponding param
* Replace ref{le|ra}cted crypto params ptr args with single flags arg
* Simplify logic for regular cryptomatte in cRR0() and eliminate cryptomatteBuffer arg
* Eliminate hitVolume param from cRR0()
* Eliminate ignoreVolumes param from cRR0()
* Tidy up logic for indirectFlags and doIndirect in cRR0()
* Make cRR0() return the radiance rather than pass it as a reference
* Consolidate some early outs and their corresponding aov processing in cRR0()
* Temporarily remove deferred nodes
* Add computeRadiancePresence() func
* Add computeRadianceSubsurface() func
* Fix a bug
* Fix more bugs
* Organise and comment a bit
* Factor out lights-visible-in-camera stuff and reduce logic on early-out for no bsdf lobes
* Find more appropriate locations for some bits of code
* Factor out the computing of cryptomatte results
* Add changes which should have been included in previous commit
* Fix build errors in some variants
* Fix RayState padding for mac os
* copilot suggestion 1
Add safety checks for construction of TypedAttributeKeys.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Copilot suggestion 2 (include file)
* Copilot suggestion 3 - bug fix
* Copilot suggestion 4 - bug fix
* Apply round 1 of code review feedback
* Fix build error
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Jon Lanz <jon.lanz@dreamworks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves OpenMoonRay/openmoonray#254
Add dedicated version of CRR() for ray depth 0
Remove tests for ray depth 0
Remove redundant params from CRR1()
Minor simplifications
Further minor simplifications
Eliminate ignoreVolumes and hitVolume params from CRR1()
Eliminate IndirectRadianceType flags and make CRR() funcs return type be void
Tidy up logic for indirectFlags and doIndirect
Make CRR1() return the radiance rather than pass it as a reference
Reduce processing for ref{le|ra}cted cryptomatte in CRR1()
Remove redundant variable & corresponding param
Replace ref{le|ra}cted crypto params ptr args with single flags arg
Simplify logic for regular cryptomatte in cRR0() and eliminate cryptomatteBuffer arg
Eliminate hitVolume param from cRR0()
Eliminate ignoreVolumes param from cRR0()
Tidy up logic for indirectFlags and doIndirect in cRR0()
Make cRR0() return the radiance rather than pass it as a reference
Consolidate some early outs and their corresponding aov processing in cRR0()
Temporarily remove deferred nodes
Add computeRadiancePresence() func
Add computeRadianceSubsurface() func
Fix a bug
Fix more bugs
Organise and comment a bit
Factor out lights-visible-in-camera stuff and reduce logic on early-out for no bsdf lobes
Find more appropriate locations for some bits of code
Factor out the computing of cryptomatte results
Add changes which should have been included in previous commit
Fix build errors in some variants
Fix RayState padding for mac os
copilot suggestion 1
Add safety checks for construction of TypedAttributeKeys.
Co-authored-by: Copilot 175728472+Copilot@users.noreply.github.com
Copilot suggestion 2 (include file)
Copilot suggestion 3 - bug fix
Copilot suggestion 4 - bug fix
Apply round 1 of code review feedback
Fix build error
Co-authored-by: Copilot 175728472+Copilot@users.noreply.github.com
Signed-off-by: Jon Lanz jon.lanz@dreamworks.com