fix(razer): correct DeathAdder V4 Pro polling and DPI ceilings - #40
Merged
Conversation
Cross-referenced against openrazer/openrazer#2508 (merged), the PR that added DeathAdder V4 Pro support to OpenRazer: - The wired PID (0x00be) was defaulting to MODERN_WIRED's usual 1000 Hz cap, but openrazer's POLL_RATES for both its wired and wireless classes go to 8000 Hz (a HyperPolling receiver ships in the box even for the cabled mode) — give it its own highRatePolling override, same pattern as the Viper V3 Pro's wired/wireless split. - Both PIDs were using the shared 35K-generation DPI ceiling, but openrazer documents this model's own DPI_MAX = 45000 (and separately raised the driver's shared set-DPI clamp to accommodate it) — added a DPI_DEATHADDER_V4_PRO constant rather than reusing DPI_FOCUS_PRO_35K, which several unrelated 35K-sensor mice still correctly cap at. Both PIDs stay nativeOnly: true — unchanged, and still correct per this file's own note that the control channel sits on a Chrome-protected collection (Chrome/WebHID's page-protection, not a hardware limitation), so these facts only matter to a native-HID consumer like openmouse-desktop. Full test suite passes (572/572), including the guard that already caught the highRatePolling/pollingRates mismatch on first attempt. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross-referenced against openrazer/openrazer#2508 (merged), which added DeathAdder V4 Pro support upstream:
MODERN_WIRED's usual 1000 Hz cap, but openrazer'sPOLL_RATESfor both its wired and wireless classes go to 8000 Hz — gave it its ownhighRatePollingoverride, mirroring the Viper V3 Pro's wired/wireless split.DPI_MAX = 45000. Added a dedicatedDPI_DEATHADDER_V4_PROconstant rather than reusingDPI_FOCUS_PRO_35K, which other 35K-sensor mice still correctly cap at.Both PIDs stay
nativeOnly: true— the control channel sits on a Chrome-protected collection (Chrome/WebHID's own restriction, not a hardware one, per this file's existing note), so these facts matter to a native-HID consumer like openmouse-desktop rather than the web app.Full test suite passes (572/572), including the existing guard that caught the highRatePolling/pollingRates mismatch on the first pass.