Add Nape Pro onboard assignments and orientation on Profiles (rebased) - #136
Merged
Conversation
# Conflicts: # src/device/controller.ts
Both branches already converged on the same class: dev had aliased KeychronNapeHidClient as KeychronHidClient for its pre-existing sleep-options usage, while this PR imports it directly as KeychronNapeHidClient for the new layer/orientation controls. This PR's own controller.ts already renamed all of dev's prior usages, so keeping its direct import is sufficient.
Deploying openmouse with
|
| Latest commit: |
ea0dbe9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://921104b8.openmouse.pages.dev |
| Branch Preview URL: | https://nape-pro-app-resolved.openmouse.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase of #118 onto dev after the protocol bump (#132). Both branches had independently converged on
KeychronNapeHidClient(dev via an alias for its pre-existing sleep-options code, this PR directly for the new layer/orientation controls); kept this PR's direct import since its controller.ts already renamed dev's prior usages. Build, bundle-size check, and full test suite (85/85) pass.Closes #118.