supported devices: add the VXE R1 on both transports - #156
Open
SakethKanchi wants to merge 1 commit into
Open
Conversation
The ATK driver now identifies VXE mice by CID/MID and claims VXE's wired transport, so the R1 is supported over its 2.4 GHz receiver (0x1085) and wired (0xf58f). Both are shared product ids, hence the note pointing at the CID/MID identity rather than the ids. Register VXE as a driver-reported brand alongside CRDRAKO, and pin both product ids in the PID universe: the ATK filter matches on vendor plus usage page, so the protocol pins no ATK product ids of its own.
|
Continued the R1 work in #163, depending on protocol PR OpenMouse-Project/mouse-protocol#53. #163 retains your original app commit in its history, narrows the claim to the physically tested wired R1 SE+, and adds Chromium WebHID read/write verification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the VXE R1 to the supported-devices table on both of its transports.
Depends on OpenMouse-Project/mouse-protocol#44, which makes the ATK driver
identify VXE mice by CID/MID and claim VXE's wired transport. Please merge that
first — until it lands (and
openmouse's git dependency picks it up), thesupportedclaim here is only true against a local build.Changes
supported-mice.ts: one row,pids: [0x1085, 0xf58f]— the 2.4 GHz receiver andwired. Both are shared product ids, so the note points at the CID/MID
identity (
2,12, PAW3395) rather than implying the ids identify the model.supported-mice.test.ts:VXEregistered as a driver-reported brand, alongside the existingCRDRAKOentry — the ATK driver reports it via
deviceBrand().PID_UNIVERSE. The ATK discovery filter matches onvendor + usage page, so the protocol pins no ATK product ids of its own;
0xf58fis pinned byATK_COMPX_PRODUCT_IDSbecause it sits under the shared0x3554.No driver or controller wiring was needed:
AtkHidClientis already imported insrc/device/controller.tsand grouped inDM_CLASSES/DEDICATED.Verification
npm run checkpasses (112 tests) with mouse-protocol#44 installed locally perCONTRIBUTING's overlay recipe.
Verified in Chrome over WebHID on a real VXE R1 (firmware
Mouse 3.13): the deviceconnects through the picker without crashing, names itself VXE R1, shows brand
VXE, 1,000 Hz, lift-off Low, Motion Sync on, ripple off, and angle snapping asN/A(its angle register is unprogrammed). DPI tracked the mouse's own DPI-buttonstage correctly — 1,200 DPI on stage 1, 1,600 on stage 2.
Battery also now shows a real charge state rather than "Unknown" —
Chargingonthe cable,
Dischargingon the receiver.Before the protocol fix the same device showed
ATK Wireless mouse -1k dongleat320 DPI.
Note for a maintainer
ui/device-images.tshas no R1 asset and matches artwork by display-name regex, soVXE R1falls back tounknown-device.png. I deliberately did not map it toanother model's render.