Change: Throw out per-grf industry tile limit.

[PeterN]

Motivation / Problem

The custom industry tile limit was set to 255 per-GRF based on the premise that action 3 ids might later be extended.

They have since been extended.

Description

Raise the limit to account for the action 3 extended byte change.

Limit is now the total number of custom tiles that can be used.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

• The bug fix is important enough to be backported? (label: 'backport requested')
• This PR touches english.txt or translations? Check the guidelines
• This PR affects the save game format? (label 'savegame upgrade')
• This PR affects the GS/AI API? (label 'needs review: Script API')
  • ai_changelog.hpp, game_changelog.hpp need updating.
  • The compatibility wrappers (compat_*.nut) need updating.
• This PR affects the NewGRF API? (label 'needs review: NewGRF')
  • newgrf_debug_data.h may need updating.
  • PR must be added to API tracker

[2TallTyler]

Makes sense to me.

For later reference, the Action 03 extension was in #10672, if I'm reading this right.

Does NML need to be patched?

[PeterN]

Hmm, NML source code says:

# Maximum allowed id (houses and indtiles in principle allow up to 511, but action3 does not accept extended bytes).

So, not sure how that interacts with the way original IDs can't be reused.

[michicc]

Increasing the limit shouldn't break anything in NML by itself, should it? It will just not allow more tiles, but that wouldn't preclude merging the PR.

[PeterN]

I can't really remember why I referenced that. I think I may have been thinking along the lines of should the limit be 511 or 337.

[michicc]

Added to https://wiki.openttd.org/edit/en/Development/NewGRF/Specification%20Status anyway.

[rubidium42]

Is there a reason for not merging this? Besides a hefty rebase being needed to run the right build checks.

[andythenorth]

"Can haz merge?" 😸

[andythenorth]

nfo and nml spec updated. Wiki specification status page updated. nml patch is OpenTTD/nml#438