Add: Output warning if a similar name (case-insensitive) has been defined before - #439
Open
PeterN wants to merge 1 commit into
Open
Add: Output warning if a similar name (case-insensitive) has been defined before#439PeterN wants to merge 1 commit into
PeterN wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #427 an author had inadvertently mixed up cases of item names and experienced unexpected behaviour. In NML item names are case-sensitive, so using different cases results in a different item.
This PR adds a check for existing item names that differ only by case, and outputs a warning if found.
Item names are still case-sensitive, so there is no behaviour difference and therefore existing sets that rely on this should not break.
Closes #427.