test: migrate Debian fixture to Trixie - #37
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is small, localized to a unit-test fixture string, and does not alter production logic.
Pull request overview
This PR updates the Debian-based TypeScript devcontainer image tag used in the discoverDevcontainerConfig unit test fixture from Debian Bookworm to Debian Trixie, keeping Ubuntu-based fixtures unchanged.
Changes:
- Update the nested devcontainer fixture image reference from
...:1-22-bookwormto...:1-22-trixieintests/core.test.ts. - Update the corresponding assertion to match the new fixture value.
File summaries
| File | Description |
|---|---|
tests/core.test.ts |
Updates the devcontainer image tag string used as a test fixture to reflect Debian Trixie. |
Review details
Suppressed comments (1)
tests/core.test.ts:484
- Same as above: update the expected fixture image string to a published tag so the test stays representative of real devcontainer images.
expect(discovered.config.image).toBe("mcr.microsoft.com/devcontainers/typescript-node:1-22-trixie");
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
PabloZaiden
disabled auto-merge
August 29, 2026 21:51
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PabloZaiden
enabled auto-merge (squash)
August 29, 2026 21:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
bun run typecheckbun test tests/core.test.ts