Skip to content

test: migrate Debian fixture to Trixie - #37

Merged
PabloZaiden merged 2 commits into
mainfrom
chat-devbox-1-e4f3f3f9
Aug 29, 2026
Merged

test: migrate Debian fixture to Trixie#37
PabloZaiden merged 2 commits into
mainfrom
chat-devbox-1-e4f3f3f9

Conversation

@PabloZaiden

Copy link
Copy Markdown
Owner

Summary

  • Migrate the Debian-based TypeScript devcontainer fixture from Bookworm to Trixie.
  • Keep all Ubuntu-based images and configuration unchanged.

Validation

  • bun run typecheck
  • bun test tests/core.test.ts

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings August 29, 2026 21:47
@PabloZaiden
PabloZaiden enabled auto-merge (squash) August 29, 2026 21:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is small, localized to a unit-test fixture string, and does not alter production logic.

Pull request overview

This PR updates the Debian-based TypeScript devcontainer image tag used in the discoverDevcontainerConfig unit test fixture from Debian Bookworm to Debian Trixie, keeping Ubuntu-based fixtures unchanged.

Changes:

  • Update the nested devcontainer fixture image reference from ...:1-22-bookworm to ...:1-22-trixie in tests/core.test.ts.
  • Update the corresponding assertion to match the new fixture value.
File summaries
File Description
tests/core.test.ts Updates the devcontainer image tag string used as a test fixture to reflect Debian Trixie.
Review details

Suppressed comments (1)

tests/core.test.ts:484

  • Same as above: update the expected fixture image string to a published tag so the test stays representative of real devcontainer images.
    expect(discovered.config.image).toBe("mcr.microsoft.com/devcontainers/typescript-node:1-22-trixie");
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread tests/core.test.ts Outdated
@PabloZaiden
PabloZaiden disabled auto-merge August 29, 2026 21:51
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@PabloZaiden
PabloZaiden enabled auto-merge (squash) August 29, 2026 21:53
@PabloZaiden
PabloZaiden merged commit b4e4ccc into main Aug 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants