Fix IMEX RK on GPU#654
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a GPU-specific failure in the IMEX Runge–Kutta sweeper by ensuring the stage right-hand side is created as an independent dtype_u object (instead of aliasing lvl.u[0]), avoiding unintended in-place modification / shallow-copy aliasing on array-backed GPU data types.
Changes:
- Initialize
rhsviaprob.dtype_u(lvl.u[0])to force a deep copy rather than referencinglvl.u[0]. - Assign
lvl.u[m+1]directly fromrhsinstead of usingrhs[:], avoiding view/alias semantics for ndarray-like types.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Good catch. These bugs suck, big time. |
Member
|
Classic : programming in python looks easy, but properly doing it is not 😅 |
Member
|
I'm glad we now have AI for th.. oh, wait.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ok, sometimes I see why people are frustrated with Python. This deep-copy / shallow copy bug that made RK443 blow up on GPUs was quite hard to find...