Fix TypeError when tree expand/collapse/search is used before the tree finished loading - #1482
Merged
Merged
Conversation
The collapseAll(), expandAll() and searchInput() actions dereference this._tree, which is only assigned in _fillTree() after the tree data has been fetched asynchronously. Triggering one of these actions (clicking expand/collapse-all or typing in the tree search box) before the data has loaded threw 'TypeError: Cannot read properties of null (reading ...)'. Guard the three actions with the existing _isInitialized() helper so they are no-ops until the tree is ready.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1482 +/- ##
============================================
- Coverage 60.06% 60.04% -0.03%
Complexity 9057 9057
============================================
Files 675 675
Lines 29432 29432
============================================
- Hits 17677 17671 -6
- Misses 11755 11761 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
looks good. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The sidebar tree's
collapseAll(),expandAll()andsearchInput()Stimulus actions call methods onthis._tree, which is only assigned in_fillTree()after the tree data has been fetched asynchronously (_getData()inreinitTree()).If the expand-all / collapse-all button is clicked, or something is typed into the tree search box, before that fetch completes,
this._treeis stillnulland the browser throws:It is easy to hit on a cold cache / slow first load. The tree works normally once loaded — this is just an unhandled early interaction.
Fix
Guard the three actions with the controller's existing
_isInitialized()helper (it already returnsthis._tree !== null), so they are no-ops until the tree is ready. One short guard per method; no behaviour change once the tree has loaded.