Skip to content

Fix Minion Pact damage applying without nearby minions#1906

Merged
LocalIdentity merged 3 commits into
PathOfBuildingCommunity:devfrom
unrealdreamz:fix/minion-pact-requires-active-minion
May 23, 2026
Merged

Fix Minion Pact damage applying without nearby minions#1906
LocalIdentity merged 3 commits into
PathOfBuildingCommunity:devfrom
unrealdreamz:fix/minion-pact-requires-active-minion

Conversation

@unrealdreamz
Copy link
Copy Markdown
Contributor

Summary

  • Gate Minion Pact I/II's more-damage stat behind the existing "# of Minions in your Presence" configuration.
  • Keep both exported support data and generated skill data aligned.
  • Add a regression covering Lightning Arrow with Minion Pact before and after a minion-in-presence count is configured.

Root Cause

Minion Pact's data description says it only takes effect when there is a minion with enough life to drain, but the stat map emitted an unconditional Damage MORE modifier. As a result, any supported player skill received Minion Pact damage even when the build had no minion state at all.

Fix

The support stat now carries a MultiplierThreshold on MinionPresenceCount >= 1. This reuses the existing configuration path for nearby minions instead of adding a new UI surface or inventing broader minion simulation.

Validation

  • gh pr list --repo PathOfBuildingCommunity/PathOfBuilding-PoE2 --state open -S '1724' --json number,title,headRefName,author,url --jq '.'[]
  • gh pr list --repo PathOfBuildingCommunity/PathOfBuilding-PoE2 --state open -S '"Minion Pact"' --json number,title,headRefName,author,url --jq '.'[]
  • git diff --check → pass (CRLF warning only)
  • git diff --cached --check → pass (CRLF warning only)
  • git show --check --stat --oneline HEAD → pass

I did not run the containerized Busted suite locally; this machine is currently being kept free of extra containers/windows. The included spec is targeted at the changed support stat path.

Risk / Rollback

Risk is localized to Minion Pact I/II. Builds using Minion Pact now need an explicit minion-in-presence count for its conditional damage to apply. Rollback is a revert of this commit.

Fixes #1724

Copy link
Copy Markdown
Contributor

@LocalIdentity LocalIdentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relies on logic from #1835

@LocalIdentity LocalIdentity added the bug: behaviour Behavioral differences label May 23, 2026
@LocalIdentity LocalIdentity merged commit 29af770 into PathOfBuildingCommunity:dev May 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: behaviour Behavioral differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible bug with Minion Pact + Wolf Pack

2 participants