Allow fractional skill counts#1916
Open
unrealdreamz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1708.
Allows decimal values in skill Count fields so users can model partial uptime / average-use contributions through the existing Full DPS count scalar.
Root Cause
The Full DPS calculation path already multiplies by numeric count values, and XML save/load already serializes them with
tonumber/tostring. The practical blockers were the UI and text paths:count >= 2, hiding values like0.5xeven though the DPS was scaled.Fix
1.1Full DPS count in labels/export, including values below1.0.5count is preserved and halves Full DPS.Validation
Local, non-GUI validation only:
I did not run Busted locally because this Windows checkout does not have Lua/LuaJIT/Busted on PATH. I also avoided Docker/GUI validation so no visible command windows or heavy processes were launched.
Risk / Rollback
Low-to-moderate risk. This does not change Full DPS semantics; it only lets decimal counts reach the existing scalar and makes the display honest. Rollback is this commit.