Skip to content

Scale Vile Effusion by active Chaos DoT debuffs#1926

Open
unrealdreamz wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
unrealdreamz:fix/dark-effigy-chaos-dot-count
Open

Scale Vile Effusion by active Chaos DoT debuffs#1926
unrealdreamz wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
unrealdreamz:fix/dark-effigy-chaos-dot-count

Conversation

@unrealdreamz
Copy link
Copy Markdown
Contributor

Summary

Fixes #564.

Dark Effigy's hidden Vile Effusion skill now scales from the number of active Chaos damage over time debuffs that the current build can maintain on the enemy.

Root Cause

Vile Effusion is exported with ProjectilesNumberModifiersNotApplied and a static number_of_additional_projectiles = 100 placeholder. The generic projectile path can display that static value, but it does not encode the actual mechanic from the skill text: one projectile/DPS instance per Chaos DoT debuff on the target, with normal projectile-count modifiers ignored.

That left Contagion, Essence Drain, Decaying Hex-supported curses, and Poison unable to change Dark Effigy's calculated DPS.

Fix

  • Add a small Vile Effusion-specific Chaos DoT debuff counter.
  • Count enabled active skills that represent Chaos DoT debuffs, including support-granted decay from Decaying Hex.
  • Count Poison once when either the enemy Poisoned condition is enabled or an enabled active skill has Poison chance.
  • Apply the count as Vile Effusion's effective projectile count and DPS multiplier.
  • Keep the behavior scoped to Vile Effusion; generic projectile modifiers remain ignored as the skill text requires.

Validation

  • Checked for duplicate/overlapping PRs:
  • Added a focused regression spec covering:
    • no Chaos DoT debuffs => zero Vile Effusion DPS/projectiles
    • Contagion adds one debuff
    • Essence Drain adds one debuff
    • Temporal Chains + Decaying Hex adds one debuff
    • Poison support adds one debuff
    • manually setting enemy Poisoned does not double-count Poison
  • Lua syntax compile via Lupa:
    • PASS lua compile src/Modules/CalcOffence.lua
    • PASS lua compile spec/System/TestSkills_spec.lua
  • git diff --check passed.
  • git show --check --stat --oneline --no-renames HEAD passed.

Local Busted/Docker validation was not run because this Windows checkout does not currently have lua, luajit, busted, docker, or docker-compose on PATH.

Risk / Rollback

Risk is limited to the hidden Vile Effusion skill path. The change does not alter generic projectile-count math, generic totem logic, or other Chaos DoT skill damage.

Rollback is the single commit on this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dark Effigy appears to not scale with appropriate skills.

1 participant