Fix inculsion of unique jewels when comparing passive trees#1932
Open
oboking wants to merge 1 commit into
Open
Fix inculsion of unique jewels when comparing passive trees#1932oboking wants to merge 1 commit into
oboking wants to merge 1 commit into
Conversation
… the compared builds jewel when hovering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
If the build you are comparing with has certain jewels, they are sometimes not included when comparing the passive trees.
Changes:
Link to a build that showcases this PR:
As a main build, you can firstly import this, it has an overlapping jewel slot with the second build.
Import this secondly to compare with. That build uses both unique radius jewels as well as a "From Nothing" jewel.
Before screenshot:
A build that included jewels like the ones in this image (regular Tree tab)
Resulted in the tree in the compare tab not showing anything at all in those slots, and also not including the radiuses.
After screenshot:
When hovering slots with different jewels, you will see both. Radiuses are colored in the same way other passives nodes/paths differences are colored in the compare tab.
