Skip to content

Vector: allowDropAnywhere = true for roundingFunctions menu#162

Open
embinmc wants to merge 5 commits into
PenguinMod:developfrom
embinmc:develop
Open

Vector: allowDropAnywhere = true for roundingFunctions menu#162
embinmc wants to merge 5 commits into
PenguinMod:developfrom
embinmc:develop

Conversation

@embinmc

@embinmc embinmc commented Oct 15, 2025

Copy link
Copy Markdown

allowDropAnywhere = false is EVIL!!!! make it true!

will just return the vector unmodified if invalid rounding method is chosen or whatevs

maybe works :trollface:

@embinmc

embinmc commented Oct 15, 2025

Copy link
Copy Markdown
Author

waait theres a semicolon

@jwklong

jwklong commented Oct 16, 2025

Copy link
Copy Markdown
Member

will need to check if this affects already existing blocks

@Steve0Greatness

Copy link
Copy Markdown

Pretty sure it wouldn't excluding extenuating circumstances such as someone having directly modified their project JSON.

@jwklong

jwklong commented Nov 8, 2025

Copy link
Copy Markdown
Member

i need to check if changing a menu from no reporter to yes reporter breaks previous projects that use that block

@jwklong

jwklong commented Nov 8, 2025

Copy link
Copy Markdown
Member

oops I already said that

@jwklong

jwklong commented Nov 8, 2025

Copy link
Copy Markdown
Member

Pretty sure it wouldn't excluding extenuating circumstances such as someone having directly modified their project JSON.

yeah but aren't no accept menu values stored differently to yes accept menu

@RedMan13

RedMan13 commented Nov 8, 2025

Copy link
Copy Markdown

yeah but aren't no accept menu values stored differently to yes accept menu

indeed, as accept reports is input>shadow>field and none accepting is just field
and also the serializer simply doesnt know any better than what the save says is true, so it will inevitably cause old projects to have those menus be empty and unusable

@jwklong

jwklong commented Nov 8, 2025

Copy link
Copy Markdown
Member

sooo merging this would be bad

@embinmc

embinmc commented Nov 8, 2025

Copy link
Copy Markdown
Author

sooo merging this would be bad

nooooooooo

@jwklong

jwklong commented Nov 8, 2025

Copy link
Copy Markdown
Member

nooooooooo

its going to break ALL the projects...

@embinmc

embinmc commented Nov 8, 2025

Copy link
Copy Markdown
Author

what if.... we make a NEW block and menu instead of updating the existing one....

@RedMan13

RedMan13 commented Nov 8, 2025

Copy link
Copy Markdown

i mean yeah thats.... kinda exactly what should be done 🥱

@embinmc

embinmc commented Nov 8, 2025

Copy link
Copy Markdown
Author

i used my Magical Powers™ to cast a Magical Spell™ to do allathat

@jwklong

jwklong commented Nov 8, 2025

Copy link
Copy Markdown
Member

mmgghhh i mean at this point couldn't you just put a switch statement in a custom block and let that do rounding menu thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants