Skip to content

Add new option to toml file to exclude package is old enough - #1244

Merged
mpgn merged 21 commits into
mainfrom
mpgn-patch-1
Jul 31, 2026
Merged

Add new option to toml file to exclude package is old enough#1244
mpgn merged 21 commits into
mainfrom
mpgn-patch-1

Conversation

@mpgn

@mpgn mpgn commented May 19, 2026

Copy link
Copy Markdown
Collaborator

Description

uv will only consider package artifacts whose upload timestamp is older than the configured cutoff. This helps avoid installing newly published package releases until they have aged for at least one day.

I also started the switch to UV without breaking any logic with poetry, both works fine but uv is just better and faster and fully compatible with pyproject.toml

Type of change

Insert an "x" inside the brackets for relevant items (do not delete options)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Deprecation of feature or functionality
  • This change requires a documentation update
  • This requires a third party update (such as Impacket, Dploot, lsassy, etc)
  • This PR was created with the assistance of AI (list what type of assistance, tool(s)/model(s) in the description)

Setup guide for the review

Please provide guidance on what setup is needed to test the introduced changes, such as your locally running machine Python version & OS, as well as the target(s) you tested against, including software versions.
In particular:

  • Bug Fix: Please provide a short description on how to trigger the bug, to make the bug reproducable for the reviewer.
  • Added Feature/Enhancement: Please specify what setup is needed in order to test the changes, such as:
    • Is additional software needed?
    • GPO changes required?
    • Specific registry settings that need to be changed?

Screenshots (if appropriate):

Screenshots are always nice to have and can give a visual representation of the change.
If appropriate, include before and after screenshot(s) to show which results are to be expected.

Checklist:

Insert an "x" inside the brackets for completed and relevant items (do not delete options)

  • I have ran Ruff against my changes (poetry: poetry run ruff check ., use --fix to automatically fix what it can)
  • I have added or updated the tests/e2e_commands.txt file if necessary (new modules or features are required to be added to the e2e tests)
  • If reliant on changes of third party dependencies, such as Impacket, dploot, lsassy, etc, I have linked the relevant PRs in those projects
  • I have linked relevant sources that describes the added technique (blog posts, documentation, etc)
  • I have performed a self-review of my own code (not an AI review)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (PR here: https://github.com/Pennyw0rth/NetExec-Wiki)

mpgn added 2 commits May 19, 2026 20:22
Signed-off-by: mpgn <5891788+mpgn@users.noreply.github.com>
Signed-off-by: mpgn <5891788+mpgn@users.noreply.github.com>
mpgn added 10 commits May 19, 2026 21:01
Add min-release-age setting for supply-chain hardening

Signed-off-by: mpgn <5891788+mpgn@users.noreply.github.com>
Signed-off-by: mpgn <5891788+mpgn@users.noreply.github.com>
Signed-off-by: mpgn <5891788+mpgn@users.noreply.github.com>
Updated GitHub Actions workflow to use 'uv' for installation and execution.

Signed-off-by: mpgn <5891788+mpgn@users.noreply.github.com>
Signed-off-by: mpgn <5891788+mpgn@users.noreply.github.com>
Signed-off-by: mpgn <5891788+mpgn@users.noreply.github.com>
Signed-off-by: mpgn <5891788+mpgn@users.noreply.github.com>
Signed-off-by: mpgn <5891788+mpgn@users.noreply.github.com>
Signed-off-by: mpgn <5891788+mpgn@users.noreply.github.com>
@NeffIsBack NeffIsBack added the dependencies Pull requests that update a dependency file label May 19, 2026
@NeffIsBack

Copy link
Copy Markdown
Member

Can you add the stuff from the poetry.toml to the pyproject.toml as well? Would be nice to have everything in there instead of heaving tons of additional files

@mpgn

mpgn commented May 20, 2026

Copy link
Copy Markdown
Collaborator Author

Can you add the stuff from the poetry.toml to the pyproject.toml as well? Would be nice to have everything in there instead of heaving tons of additional files

Nop, Poetry intentionally keeps local environment-specific configs out of pyproject.toml, this is why i initiate the switch to uv

@NeffIsBack

Copy link
Copy Markdown
Member

Can you add the stuff from the poetry.toml to the pyproject.toml as well? Would be nice to have everything in there instead of heaving tons of additional files

Nop, Poetry intentionally keeps local environment-specific configs out of pyproject.toml, this is why i initiate the switch to uv

oof okay, i guess then yet another file

Comment thread .github/workflows/lint.yml Outdated
Comment thread .github/workflows/lint.yml
mpgn and others added 5 commits July 15, 2026 15:48
Signed-off-by: mpgn <5891788+mpgn@users.noreply.github.com>
Signed-off-by: mpgn <5891788+mpgn@users.noreply.github.com>
@mpgn

mpgn commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator Author

should be good to review @NeffIsBack :)

Comment thread pyproject.toml Outdated
mpgn added 3 commits July 15, 2026 21:31
Removed specific dependencies from the dev group in pyproject.toml and added a comment about the uv and poetry native dev group.

Signed-off-by: mpgn <5891788+mpgn@users.noreply.github.com>
Signed-off-by: mpgn <5891788+mpgn@users.noreply.github.com>

@NeffIsBack NeffIsBack left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Image

Fyi, with an update to ruff we got a lot of work... We should update all packages relatively soon and probably add python 3.14 compatibility. Gonna put that on my todo list.
Image

@NeffIsBack

Copy link
Copy Markdown
Member

For the future we have to keep in mind to update both the poetry as well as the uv lock file. Maybe we should even remove both to be on consistent with both tools and additionally always have the latest packages. Then we are also on the same packages as people with pipx are.

@mpgn
mpgn merged commit d24af22 into main Jul 31, 2026
10 checks passed
@mpgn
mpgn deleted the mpgn-patch-1 branch July 31, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants