Add reg-query support for MSSQL#1256
Open
Dfte wants to merge 4 commits into
Open
Conversation
Dfte
requested review from
Marshall-Hallenbeck,
NeffIsBack,
mpgn and
zblurx
as code owners
June 1, 2026 15:04
Member
|
Very nice! |
azoxlpf
suggested changes
Jun 1, 2026
added 2 commits
June 2, 2026 10:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support to the reg-query module for the MSSQL protocol. MSSQL allows reading, deleting and adding registry keys via multiple stored procedure. As such, and if you have admin privileges via the MSSQL server (means it is running as a local administrator), you can query, add and delete registry keys.
Type of change
Insert an "x" inside the brackets for relevant items (do not delete options)
Setup guide for the review
Spawn a MSSQL DB and run the commands above.
Screenshots (if appropriate):
Checklist:
Insert an "x" inside the brackets for completed and relevant items (do not delete options)
poetry run ruff check ., use--fixto automatically fix what it can)tests/e2e_commands.txtfile if necessary (new modules or features are required to be added to the e2e tests)