Add ldap timeout option to ldap protocol - #1313
Merged
Merged
Conversation
Add a --ldap-timeout option (default 10s) and pass it through to impacket's LDAPConnection, which now supports a native connection timeout (fortra/impacket#2217). Also deprecate the generic --timeout flag and bump the pinned impacket to the commit that ships the timeout parameter.
mpgn
requested review from
Marshall-Hallenbeck,
NeffIsBack and
zblurx
as code owners
July 15, 2026 14:00
Member
|
Nice one! |
NeffIsBack
reviewed
Jul 16, 2026
Signed-off-by: mpgn <5891788+mpgn@users.noreply.github.com>
…nto ldaptiemout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Add a --ldap-timeout option (default 10s) and pass it through to impacket's LDAPConnection, which now supports a native connection timeout (fortra/impacket#2217). Also deprecate the generic --timeout flag and bump the pinned impacket to the commit that ships the timeout parameter.
Type of change
Insert an "x" inside the brackets for relevant items (do not delete options)
Setup guide for the review
Just run with ldap
Screenshots (if appropriate):
Checklist:
Insert an "x" inside the brackets for completed and relevant items (do not delete options)
poetry run ruff check ., use--fixto automatically fix what it can)tests/e2e_commands.txtfile if necessary (new modules or features are required to be added to the e2e tests)