Skip to content

Add ldap timeout option to ldap protocol - #1313

Merged
mpgn merged 7 commits into
mainfrom
ldaptiemout
Jul 21, 2026
Merged

Add ldap timeout option to ldap protocol#1313
mpgn merged 7 commits into
mainfrom
ldaptiemout

Conversation

@mpgn

@mpgn mpgn commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Description

Add a --ldap-timeout option (default 10s) and pass it through to impacket's LDAPConnection, which now supports a native connection timeout (fortra/impacket#2217). Also deprecate the generic --timeout flag and bump the pinned impacket to the commit that ships the timeout parameter.

Type of change

Insert an "x" inside the brackets for relevant items (do not delete options)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Deprecation of feature or functionality
  • This change requires a documentation update
  • This requires a third party update (such as Impacket, Dploot, lsassy, etc)
  • This PR was created with the assistance of AI (list what type of assistance, tool(s)/model(s) in the description)

Setup guide for the review

Just run with ldap

Screenshots (if appropriate):

image

Checklist:

Insert an "x" inside the brackets for completed and relevant items (do not delete options)

  • I have ran Ruff against my changes (poetry: poetry run ruff check ., use --fix to automatically fix what it can)
  • I have added or updated the tests/e2e_commands.txt file if necessary (new modules or features are required to be added to the e2e tests)
  • If reliant on changes of third party dependencies, such as Impacket, dploot, lsassy, etc, I have linked the relevant PRs in those projects
  • I have linked relevant sources that describes the added technique (blog posts, documentation, etc)
  • I have performed a self-review of my own code (not an AI review)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (PR here: https://github.com/Pennyw0rth/NetExec-Wiki)

Add a --ldap-timeout option (default 10s) and pass it through to
impacket's LDAPConnection, which now supports a native connection
timeout (fortra/impacket#2217). Also deprecate the generic --timeout
flag and bump the pinned impacket to the commit that ships the timeout
parameter.
@mpgn mpgn changed the title Ldaptiemout Add ldap timeout option to ldap protocol Jul 15, 2026
@NeffIsBack NeffIsBack added the enhancement New feature or request label Jul 15, 2026
@NeffIsBack

Copy link
Copy Markdown
Member

Nice one!

Comment thread nxc/protocols/ldap.py

@NeffIsBack NeffIsBack left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:

Image

@mpgn
mpgn merged commit b2a9c74 into main Jul 21, 2026
10 checks passed
@mpgn
mpgn deleted the ldaptiemout branch July 21, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants