fix(tests): remove nonexistent safe_shares and fix mssql_dumper module name in e2e tests - #1357
Merged
Merged
Conversation
…e name in e2e tests - Remove safe_shares module tests (lines 155-157) — this module never existed in the codebase, causing 3 guaranteed failures - Rename mssql-dumper to mssql_dumper (lines 300-302) — the module uses an underscore, not a hyphen
Marshall-Hallenbeck
requested review from
NeffIsBack,
mpgn and
zblurx
as code owners
August 11, 2026 13:24
|
It looks like the PR template may not have been filled out. The following sections appear to be missing:
Please edit your PR description to include them. The template helps reviewers understand and test your changes. Thanks! |
Member
@Marshall-Hallenbeck the PR checker strikes back hahaha |
NeffIsBack
approved these changes
Aug 11, 2026
Collaborator
Author
|
I had AI file it of course it ignored our template 😂😂😂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix 6 guaranteed e2e test failures caused by stale module references in
tests/e2e_commands.txt:safe_shares(lines 155-157): This module never existed in the codebase. No git history, no deleted file. These 3 test lines always fail with "invalid choice."mssql-dumper(lines 303-305): The actual module name ismssql_dumper(underscore, not hyphen). These 3 test lines always fail with "invalid choice."This PR was created with the assistance of AI (Claude Code — identified the stale references during e2e test runs, verified fixes, authored the commit and PR).
Type of change
Setup guide for the review
Run the full e2e test suite against any Windows target with MSSQL:
Tested against: Windows Server 2016 DC (192.168.8.96, hacklab.ing domain), Python 3.13.14, Kali Linux.
Screenshots (if appropriate):
N/A — text-only test output change.
Checklist:
poetry run ruff check ., use--fixto automatically fix what it can)tests/e2e_commands.txtfile if necessary (new modules or features are required to be added to the e2e tests)