fix(convert): look for assets inside checkpoint_dir#1000
Open
Bartok9 wants to merge 1 commit into
Open
Conversation
Salvage of Physical-Intelligence#661 by @fecet — rebased to main. Conversion copied assets from checkpoint_dir.parent / assets; checkpoints store assets alongside weights under checkpoint_dir / assets (Physical-Intelligence#638).
Bartok9
requested review from
Michael-Equi,
jimmyt857 and
kvablack
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assetsfromcheckpoint_dir / \"assets\"instead of the parent directory when converting JAX→PyTorch.Motivation
Fixes incorrect assets discovery (#638).
Salvage of #661 by @fecet — rebased to main (original remains open/mergeable; this is a clean single-commit restate if maintainers prefer a fresh branch).
Verification
examples/convert_jax_model_to_pytorch.pyAttribution
Salvage of #661 by @fecet — rebased to main