perf(typing): replace inspect.stack with bounded frame walk#998
Open
Bartok9 wants to merge 1 commit into
Open
Conversation
Salvage of Physical-Intelligence#534 by @dcw02 — rebased to main. inspect.stack() is expensive on hot juax typing paths; walk at most 20 frames via sys._getframe while preserving the JAX/Flax skip set.
Bartok9
requested review from
Michael-Equi,
jimmyt857 and
kvablack
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inspect.stack()in the jaxtyping dataclass annotation patch with a boundedsys._getframewalk (max 20 frames).Motivation
Deep call stacks make
inspect.stack()costly on inference paths. #534 proposed a lighter walk; this rebases that idea onto currentmain(which already uses.get(\"__name__\")safely).Salvage of #534 by @dcw02 — rebased to main.
Verification
jax._src.tree_util,flax.nnx.transforms.compilationAttribution
Salvage of #534 by @dcw02 — rebased to main