Skip to content

fix(tui): show only active apps per period - #228

Merged
mike1858 merged 1 commit into
Piebald-AI:mainfrom
jimyag:fix/tui-apps-per-period
Aug 1, 2026
Merged

fix(tui): show only active apps per period#228
mike1858 merged 1 commit into
Piebald-AI:mainfrom
jimyag:fix/tui-apps-per-period

Conversation

@jimyag

@jimyag jimyag commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Show only tools that had actual activity in each Apps column period instead of including analyzers whose gap-filled daily row was empty.

Key changes

  • Skip empty analyzer-day rows when recording Apps in the combined All Tools view.
  • Preserve empty period rows and existing daily/weekly/monthly/yearly aggregation behavior.
  • Add a regression test with two tools active on different days.

Validation

  • cargo build --quiet
  • cargo test --quiet (410 passed)
  • cargo clippy --quiet -- -D warnings
  • cargo doc --quiet
  • cargo fmt --all --quiet

Summary by CodeRabbit

  • Bug Fixes

    • The “All Tools” view no longer displays empty daily entries in the Apps column.
    • Analyzer activity is now shown only for dates with recorded contributions, improving the accuracy of contribution summaries.
  • Tests

    • Added regression coverage to verify correct handling of inactive dates.

Exclude gap-filled analyzer rows from the Apps column so each aggregate period lists only tools with actual activity.

Signed-off-by: jimyag <git@jimyag.com>
@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c0bf58fd-c18a-4271-b44c-9bdf3628ca15

📥 Commits

Reviewing files that changed from the base of the PR and between f614099 and cb9d467.

📒 Files selected for processing (2)
  • src/tui.rs
  • src/tui/tests.rs

📝 Walkthrough

Walkthrough

The TUI’s “All Tools” view now includes an analyzer in a daily Apps column only when that analyzer has activity on that date. A regression test covers analyzers with activity on different dates.

Changes

All Tools daily aggregation

Layer / File(s) Summary
Filter inactive analyzers from daily Apps data
src/tui.rs, src/tui/tests.rs
build_display_stats excludes analyzers from empty periods. The regression test verifies that each date lists only the analyzer active on that date.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: mike1858

Poem

I’m a rabbit checking tools by day,
Empty dates now stay away.
Each active analyzer gets its part,
Tests confirm the daily chart.
Hop, hop—clean Apps from start to end!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: showing only active apps for each period in the TUI.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jimyag

jimyag commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

before

image

after

image

@mike1858 mike1858 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect; I've been meaning to fix this for awhile.

@mike1858
mike1858 merged commit f480a1d into Piebald-AI:main Aug 1, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants