Fix tests for older dependencies - #2287
Open
YigitElma wants to merge 14 commits into
Open
Conversation
Contributor
Memory benchmark result| Test Name | %Δ | Master (MB) | PR (MB) | Δ (MB) | Time PR (s) | Time Master (s) |
| -------------------------------------- | ------------ | ------------------ | ------------------ | ------------ | ------------------ | ------------------ |
test_objective_jac_w7x | 0.58 % | 4.236e+03 | 4.261e+03 | 24.72 | 31.09 | 26.30 |
test_proximal_jac_w7x_with_eq_update | 0.81 % | 6.806e+03 | 6.861e+03 | 54.96 | 127.24 | 128.81 |
test_proximal_freeb_jac | -0.01 % | 1.354e+04 | 1.354e+04 | -0.82 | 78.95 | 83.12 |
test_proximal_freeb_jac_blocked | 0.04 % | 7.858e+03 | 7.861e+03 | 2.99 | 72.18 | 73.86 |
test_proximal_freeb_jac_batched | 0.11 % | 7.870e+03 | 7.878e+03 | 8.74 | 70.38 | 73.04 |
test_proximal_jac_ripple | -0.12 % | 3.724e+03 | 3.720e+03 | -4.36 | 47.32 | 47.90 |
test_proximal_jac_ripple_bounce1d | 0.98 % | 3.936e+03 | 3.974e+03 | 38.39 | 58.48 | 58.49 |
test_eq_solve | -0.31 % | 1.843e+03 | 1.837e+03 | -5.78 | 43.02 | 43.33 |
test_objective_quadratic_flux_jac | 0.17 % | 1.884e+03 | 1.888e+03 | 3.19 | 30.78 | 31.35 |For the memory plots, go to the summary of |
jax-finufft related error in test_compute_everything
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2287 +/- ##
=======================================
Coverage 94.35% 94.35%
=======================================
Files 101 101
Lines 29036 29055 +19
=======================================
+ Hits 27396 27415 +19
Misses 1640 1640
🚀 New features to boost your workflow:
|
YigitElma
marked this pull request as ready for review
August 11, 2026 16:44
YigitElma
requested review from
a team,
ddudt,
dpanici,
f0uriest,
lkadz,
rahulgaur104,
singh-jaydeep and
unalmis
and removed request for
a team
August 11, 2026 16:45
ddudt
previously approved these changes
Aug 13, 2026
Draft
YigitElma
commented
Aug 16, 2026
|
|
||
| ``potrf`` only errors out, and so returns nan, when a pivot comes out | ||
| non-positive. A pivot at the noise level instead completes but gives a factor that | ||
| is useless to solve with, and which of the two a marginal matrix gets depends on |
Collaborator
Author
There was a problem hiding this comment.
For example, test_multiobject_optimization_al was creating such matrices, failing on CI for #2293, but not locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2286 (comment)
Optional
Some of the most sensitive tests like
test_solve_bounds,test_constrained_AL_lsq,etc were creating singular Jacobians (I checked the ranks) during optimization, which is something that the default QR cannot handle. This is caused by the bounds, if the objective is inside the bounds that row is full of 0s, and if there are enough rows like that, matrix becomes singular. I added a warning for this scenario (we can discuss if we want this or not). It looks at the bounded objectives and checks if they can cause rank deficiency (this is done using static info, so should be jittable for #1669). It only triggers if a user didn't givetr_methodexplicitly and the default is QR.