feat: Add fullscreen expand to plan preview#1793
Open
charlesvien wants to merge 4 commits into04-21-replace_email_cta_with_discord_link_in_readmefrom
Open
feat: Add fullscreen expand to plan preview#1793charlesvien wants to merge 4 commits into04-21-replace_email_cta_with_discord_link_in_readmefrom
charlesvien wants to merge 4 commits into04-21-replace_email_cta_with_discord_link_in_readmefrom
Conversation
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 22, 2026
6cdea85 to
d0a4b67
Compare
bc525e6 to
20a7ee1
Compare
d4fec55 to
f6b3492
Compare
Prompt To Fix All With AIThis is a comment left during a code review.
Path: apps/code/src/renderer/components/permissions/PlanContent.tsx
Line: 19-37
Comment:
**Scroll tracking breaks after mode toggle**
The scroll `useEffect` depends only on `[id]`, so when `isFullscreen` flips and `scrollRef.current` is re-bound to a different DOM node, the effect never re-runs. The listener stays on the stale (now detached) element: scroll events in the new mode go untracked, and `el.scrollTop = position` (position restoration) never fires for the newly mounted element. This directly breaks the PR's stated goal of preserving scroll position across mode toggles.
Add `isFullscreen` to the dependency array so the effect re-attaches to whichever element is currently active:
```suggestion
useEffect(() => {
const el = scrollRef.current;
if (!el) return;
const position = planScrollPosition.get(id);
if (position !== undefined) {
el.scrollTop = position;
}
const handleScroll = () => {
planScrollPosition.set(id, el.scrollTop);
};
el.addEventListener("scroll", handleScroll, { passive: true });
return () => {
el.removeEventListener("scroll", handleScroll);
};
}, [id, isFullscreen]);
```
How can I resolve this? If you propose a fix, please make it concise.
---
This is a comment left during a code review.
Path: apps/code/src/renderer/components/permissions/PlanContent.tsx
Line: 72-75
Comment:
**Superfluous opacity transition**
`transition: "opacity 150ms ease"` is set on the fullscreen overlay, but nothing in the code ever changes the element's `opacity`. The transition never fires, making this a no-op style property. Per simplicity rule #4, superfluous parts should be removed.
```suggestion
<Box
className="pointer-events-auto absolute inset-0 flex flex-col bg-gray-1"
>
```
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "Add fullscreen expand to plan preview" | Re-trigger Greptile |
774bd27 to
2c49b8a
Compare
1c25914 to
1d1d68a
Compare
c41e432 to
e7f9eec
Compare
1d1d68a to
960e351
Compare
e7f9eec to
c1caeb1
Compare
960e351 to
355c40e
Compare
341d9ba to
f8c34d6
Compare
58add1c to
07d21c3
Compare
f8c34d6 to
e951a1c
Compare
665aa02 to
4ce9fb9
Compare
e951a1c to
46afbff
Compare
4ce9fb9 to
9ac73f9
Compare
33ec432 to
2cd556e
Compare
9ac73f9 to
88d7b84
Compare
2cd556e to
482daea
Compare
88d7b84 to
62e41e9
Compare
482daea to
5805fdc
Compare
62e41e9 to
117493a
Compare
5805fdc to
2c40ec6
Compare
117493a to
d8f6b3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
Plan previews are capped at 50vh, making long plans hard to read in full.
Closes #1743
See below the screen of the inline plan preview (in blue) with the expand button on the top right of the plan and the expanded plan view (the first image).
Changes
How did you test this?
Manually