README: correct CI doc for the unpaired-PR test-run fix - #83
Open
jnasbyupgrade wants to merge 1 commit into
Open
README: correct CI doc for the unpaired-PR test-run fix#83jnasbyupgrade wants to merge 1 commit into
jnasbyupgrade wants to merge 1 commit into
Conversation
The unpaired-PR path now runs pgxntool's own test job against pgxntool-test master instead of leaving zero signal, and check-test-pr's failure there is process enforcement only -- pgxntool's master currently has no branch protection configured, so nothing technically blocks a maintainer from merging past it. Reflects pgxntool PR #109 (Postgres-Extensions/pgxntool#109, not yet merged) -- describes the pending/soon-to-land behavior, not what's live on pgxntool's master today. Co-Authored-By: Claude <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Corrects three inaccuracies in the "CI and Contributing" section of README.md:
testjob also runs against pgxntool-test master (giving a real signal), not just thatcheck-test-prfails with nothing else happening.check-test-pris a required/enforced merge check — verified viagh api repos/Postgres-Extensions/pgxntool/branches/master/protection(404, "Branch not protected"), there is currently no branch protection on pgxntool's master at all. The section is corrected to describecheck-test-pras process enforcement only.Dependency on pgxntool #109 (not yet merged)
This documents behavior introduced by Postgres-Extensions/pgxntool#109 (branch
fix-test-build-ordering), which is still open. Items 1 and 2 above describe the pending/soon-to-land.github/workflows/ci.ymlbehavior from that PR, not what's currently live on pgxntool's master. Item 3 (branch protection) is an independent, already-true correction unrelated to #109.This is a doc-only change in pgxntool-test with no pgxntool-test code/test implications, so no paired pgxntool-test... (n/a, this is the pgxntool-test repo) — no paired pgxntool PR is needed for this change itself.
Test plan
make testnot required.gh api(404, not protected)..github/workflows/ci.ymlatorigin/fix-test-build-orderingin pgxntool to confirm job/output/condition names match the doc wording exactly.