Skip to content

test: make all-chain collections coverage opt-in - #1987

Closed
omerbek wants to merge 1 commit into
ProjectOpenSea:mainfrom
omerbek:agent/gate-all-chain-collections-test-1986
Closed

test: make all-chain collections coverage opt-in#1987
omerbek wants to merge 1 commit into
ProjectOpenSea:mainfrom
omerbek:agent/gate-all-chain-collections-test-1986

Conversation

@omerbek

@omerbek omerbek commented Aug 12, 2026

Copy link
Copy Markdown

Closes #1986.

What changed

  • Replace the unconditional skip on the all-chain getCollections integration test with an explicit OPENSEA_RUN_ALL_CHAIN_COLLECTIONS=true gate.

Why

The test remains disabled by default for normal integration runs, but it is no longer permanently unreachable. Maintainers can enable the broader chain coverage in scheduled/manual CI or when validating multi-chain API behavior.

Testing

  • git diff --check
  • npm run test -- --run test/integration/getCollection.spec.ts could not run because dependencies are not installed locally (vitest not found).

@omerbek
omerbek force-pushed the agent/gate-all-chain-collections-test-1986 branch from 089b200 to 610cf77 Compare August 12, 2026 17:30
@ryanio

ryanio commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Thanks! Agreed on the reasoning: a permanently unreachable test.skip gives no coverage and no way to get any, so an explicit env gate is the right shape.

Recreated internally with you credited as co-author, and it's merged. The gate is OPENSEA_RUN_ALL_CHAIN_COLLECTIONS=true, matching your PR.

No concern about you not being able to run the suite locally, we ran it: 794 unit tests pass. Closing #1986 along with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

getCollections all-chain integration coverage is skipped

2 participants