test: make all-chain collections coverage opt-in - #1987
Closed
omerbek wants to merge 1 commit into
Closed
Conversation
omerbek
force-pushed
the
agent/gate-all-chain-collections-test-1986
branch
from
August 12, 2026 17:30
089b200 to
610cf77
Compare
Collaborator
|
Thanks! Agreed on the reasoning: a permanently unreachable Recreated internally with you credited as co-author, and it's merged. The gate is No concern about you not being able to run the suite locally, we ran it: 794 unit tests pass. Closing #1986 along with this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1986.
What changed
getCollectionsintegration test with an explicitOPENSEA_RUN_ALL_CHAIN_COLLECTIONS=truegate.Why
The test remains disabled by default for normal integration runs, but it is no longer permanently unreachable. Maintainers can enable the broader chain coverage in scheduled/manual CI or when validating multi-chain API behavior.
Testing
git diff --checknpm run test -- --run test/integration/getCollection.spec.tscould not run because dependencies are not installed locally (vitestnot found).