⚖️ ダメージ上限の引き上げ#1635
Open
haiiro2gou wants to merge 10 commits into
Open
Conversation
Member
|
要審議 |
Member
Author
|
物理炎とアポカリプスが可哀想なので闘う |
Contributor
There was a problem hiding this comment.
Pull request overview
ダメージ上限を引き上げるために、ダメージ計算側の上限値や軽減計算（防御・耐性）まわりを調整し、最終的な強制キャップ処理を共通関数として導入するPRです。
Changes:
- 最終段でのダメージ上限適用を
health_subtract/force_capに集約し、player / non-player 両経路から呼び出すよう変更 - 計算中の安全上限（オーバーフロー回避用）を 10 倍に引き上げ、軽減計算の式・スケーリングを調整
- 攻撃処理に
tellrawが追加され、ダメージスコアを出力する挙動が入っている
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| TheSkyBlessing/data/api/functions/damage/core/health_subtract/player/difficulty_modifier.mcfunction | 難易度補正内のキャップ処理を撤去（キャップを共通関数へ移動） |
| TheSkyBlessing/data/api/functions/damage/core/health_subtract/player/.mcfunction | player 側のHP減算前に force_cap を適用 |
| TheSkyBlessing/data/api/functions/damage/core/health_subtract/non-player/.mcfunction | non-player 側のHP減算前に force_cap を適用 |
| TheSkyBlessing/data/api/functions/damage/core/health_subtract/force_cap.mcfunction | 新規：システム的なダメージ上限の強制キャップ関数 |
| TheSkyBlessing/data/api/functions/damage/core/calc/resistance.mcfunction | 耐性の計算式コメント更新（ただし実装と不一致あり） |
| TheSkyBlessing/data/api/functions/damage/core/calc/defense.mcfunction | 防御計算を高ダメージ前提で再構成・スケーリング調整 |
| TheSkyBlessing/data/api/functions/damage/core/calc/.mcfunction | 計算中の安全上限（オーバーフロー回避用）を引き上げ、式コメントを更新 |
| TheSkyBlessing/data/api/functions/damage/core/attack.mcfunction | modifier 前の storage 受け渡しスケール変更、tellraw 追加、旧キャップ処理を削除 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
haiiro2gou
force-pushed
the
dev/haiiro_damage-overlimit
branch
from
7728784 to
a379cf1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
計算処理を弄ってダメージ上限を 9999.9 -> 99999.9 に上げました