fix(resources): make TipTracker.get_tip use pending state - #1206
Open
VivienP wants to merge 1 commit into
Open
Conversation
Align get_tip() with has_tip and VolumeTracker so public getters expose the same transactional view. Add regression tests for pending add and remove. Co-authored-by: Cursor <cursoragent@cursor.com>
VivienP
force-pushed
the
fix/tip-state-consistency-309
branch
from
August 29, 2026 13:06
7ddc71c to
1b4f86d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TipTracker.get_tip()withhas_tipso both expose the pending transactional state.LiquidHandlerstages removal from theTipSpotbefore calling the backend, so Hamilton backends now use theTipalready captured in the pickup operation instead of rereading the mutatedTipSpot.Hardware uncertainty /
UNKNOWNphysical state remains out of scope. This PR is independent of #1207.Test plan
Combined validation with #1207 on current
upstream/main:ruff check pylabrobotpassedruff format --check pylabrobotpassedOut of scope
Vantage.pick_up_tips96with tip tracking enabled is already broken onupstream/main: it checks pendinghas_tipafter the frontend stages removal and fails beforeget_tip()is involved. This PR does not change that pre-existing behavior.