Skip to content

updated biochar logic as CDR technology#258

Open
BertoGBG wants to merge 8 commits intoPyPSA:masterfrom
BertoGBG:biochar_pyrolysis_update_PR
Open

updated biochar logic as CDR technology#258
BertoGBG wants to merge 8 commits intoPyPSA:masterfrom
BertoGBG:biochar_pyrolysis_update_PR

Conversation

@BertoGBG
Copy link
Copy Markdown
Contributor

@BertoGBG BertoGBG commented Jan 27, 2026

Closes # (if applicable).

Changes proposed in this Pull Request

The technology biochar pyrolysis in compile_cost_assumption.py was updated with change of basis for units and additional parameters. The changes is in line with the planned implementation in pypsa-eur PyPSA/pypsa-eur#2141. Biochar pyrolysis will be implemented considered a CDR technology rather than a biomass conversion technology, and all the parameters are expressed per tonne of CO2 sequestered.

Checklist

  • [Y] Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • [Y] Data source for new technologies is clearly stated.
  • Newly introduced dependencies are added to environment.yaml (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • [Y ] I consent to the release of this PR's code under the GPLv3 license.

@BertoGBG
Copy link
Copy Markdown
Contributor Author

The test expects 7 rows for biochar pyrolysis but the code now produces 9.
The 2 extra rows come from the new biochar yield and CO2 sequestration parameters your PR added. The test update from (7, 9) → (9, 9) is correct and intentional.

I also updated the parameters name to the standard e.g. "biomass input" -> "biomass-input"

@BertoGBG
Copy link
Copy Markdown
Contributor Author

BertoGBG commented Apr 9, 2026

the output files were added and code detaisl fixed

@euronion euronion self-requested a review May 5, 2026 09:02
@euronion
Copy link
Copy Markdown
Collaborator

euronion commented May 5, 2026

Thanks for the PR and sorry for keeping you waiting for a review.

Can you elaborate what you mean by "as biochar pyrolysis is not considered as CDR technology"?
(The better the PR description and release notes are, the easier it is for us to review)
Your PR changes the units to deviate from the DEA data sheet, which does list the outputs as MWh.

Is your goal maybe to view pyrolysis as a CDR technology and change the units to reflect the costs and inputs per carbon sequestered?

@BertoGBG
Copy link
Copy Markdown
Contributor Author

BertoGBG commented May 6, 2026

your comment is spot on, it was a typo (now rather than not). I have improve the text explainng the scope and linking it to the pypsa-eur feature. it should also explain why we changed basis for the paramaters and the reason for deviating from standard technology-data unit. however it will be consistent with the pypsa-eur implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants