Skip to content

chore: Codebase cleanup after going python 3.10+ - #2988

Merged
Lulalaby merged 35 commits into
masterfrom
cleanup/39-removal-314-prepare
Jul 29, 2026
Merged

chore: Codebase cleanup after going python 3.10+#2988
Lulalaby merged 35 commits into
masterfrom
cleanup/39-removal-314-prepare

Conversation

@Lulalaby

@Lulalaby Lulalaby commented Nov 1, 2025

Copy link
Copy Markdown
Member

Depends on #2948

This basically just runs pyupgrade --py310-plus on the codebase.

@Lulalaby Lulalaby added this to the v2.7 milestone Nov 1, 2025
@Lulalaby Lulalaby added the dependencies Pull requests that update a dependency file label Nov 1, 2025
@github-project-automation github-project-automation Bot moved this to In Progress in Pycord Releases Nov 1, 2025
@pycord-app

pycord-app Bot commented Nov 1, 2025

Copy link
Copy Markdown

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/2988/head:pr-2988
git checkout pr-2988

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/2988/head

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the codebase by migrating from typing_extensions to the standard typing module for features that are now available in Python 3.10+. Since the project requires Python >= 3.10, these imports can be safely moved to the standard library. Additionally, the PR updates the event loop initialization in the Client class to avoid deprecation warnings in Python 3.11+.

Key changes:

  • Migrated TypedDict, ParamSpec, Concatenate, TypeGuard, Literal, Annotated, get_args, and get_origin from typing_extensions to typing
  • Removed Python 3.10 version checks and related code paths that are no longer needed
  • Updated event loop initialization to use asyncio.get_running_loop() with fallback to asyncio.new_event_loop() to avoid deprecation warnings

Reviewed Changes

Copilot reviewed 29 out of 29 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
discord/utils.py Migrated ParamSpec import; removed sys import, PY_310 version check, and Python < 3.10 code path for literal flattening
discord/types/*.py Migrated TypedDict from typing_extensions to typing across multiple type definition files
discord/ext/commands/core.py Migrated Concatenate, ParamSpec, and TypeGuard imports
discord/ext/commands/context.py Migrated ParamSpec import
discord/commands/core.py Removed sys import and Python 3.11 version check; migrated Annotated, Literal, get_args, get_origin, Concatenate, and ParamSpec imports
discord/commands/context.py Migrated ParamSpec import and consolidated imports on single line
discord/client.py Updated event loop initialization to avoid asyncio.get_event_loop() deprecation warning
discord/_version.py Migrated TypedDict import

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread discord/client.py Outdated
Comment thread discord/utils.py

Copilot AI commented Nov 2, 2025

Copy link
Copy Markdown

@Lulalaby I've opened a new pull request, #2989, to work on those changes. Once the pull request is ready, I'll request review from you.

@Lulalaby
Lulalaby marked this pull request as ready for review November 2, 2025 03:27
@Lulalaby
Lulalaby requested a review from a team as a code owner November 2, 2025 03:27
pre-commit-ci Bot and others added 2 commits June 8, 2026 15:43
@Paillat-dev
Paillat-dev requested a review from ToothyDev June 8, 2026 15:48
@Paillat-dev Paillat-dev modified the milestones: 2.8.1, 2.9.0rc1 Jun 8, 2026
ToothyDev
ToothyDev previously approved these changes Jun 8, 2026
@Paillat-dev
Paillat-dev requested a review from vmphase July 26, 2026 10:24
@Lulalaby
Lulalaby requested a review from a team July 26, 2026 11:22
@Lulalaby

Copy link
Copy Markdown
Member Author

i still hate you pre-commit

@Lulalaby
Lulalaby requested a review from a team as a code owner July 26, 2026 11:37
@Lulalaby
Lulalaby requested a review from Paillat-dev July 27, 2026 09:11
@Paillat-dev
Paillat-dev requested a review from ToothyDev July 29, 2026 01:00
@Lulalaby
Lulalaby enabled auto-merge (squash) July 29, 2026 01:01
@Lulalaby
Lulalaby disabled auto-merge July 29, 2026 13:57
@Lulalaby
Lulalaby merged commit fd34ae1 into master Jul 29, 2026
31 checks passed
@Lulalaby
Lulalaby deleted the cleanup/39-removal-314-prepare branch July 29, 2026 13:57
@vmphase vmphase mentioned this pull request Jul 30, 2026
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

8 participants