feat: File type filtering for Attachment options and FileUpload component - #3284
Open
NeloBlivion wants to merge 9 commits into
Open
feat: File type filtering for Attachment options and FileUpload component#3284NeloBlivion wants to merge 9 commits into
NeloBlivion wants to merge 9 commits into
Conversation
|
Thanks for opening this pull request! This pull request can be checked-out with: git fetch origin pull/3284/head:pr-3284
git checkout pr-3284This pull request can be installed with: pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3284/head |
Soheab
added
feature
Soheab
reviewed
Jul 26, 2026
Comment on lines
+2711
to
+2721
| .. attribute:: image | ||
|
|
||
| Allow image files. This includes ``.png``, ``.gif``, ``.jpg``, ``.jpeg``, ``.jfif``, ``.webp``, and ``.avif``. | ||
|
|
||
| .. attribute:: video | ||
|
|
||
| Allow video files. This includes ``.mp4``, ``.mov``, ``.qt``, and ``.webm``. | ||
|
|
||
| .. attribute:: audio | ||
|
|
||
| Allow audio files. This includes ``.mp3``, ``.m4a``, ``.wav``, ``.ogg``, ``.opus``, and ``.flac``. |
Contributor
There was a problem hiding this comment.
Documented twice? Docstring in the class too. Not sure if that's even considered.
| raise TypeError( | ||
| "items in file_types must be of type str or FileType" | ||
| ) | ||
| if len(str(f)) > 16: |
Contributor
There was a problem hiding this comment.
This also checks the length of our enum values, which is a bit useless?
Paillat-dev
added
hold: testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support
file_typesinOptionandFileUpload.Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.