Enable warm-up for RelativeDailyVolume#9442
Open
aiSynergy37 wants to merge 1 commit intoQuantConnect:masterfrom
Open
Enable warm-up for RelativeDailyVolume#9442aiSynergy37 wants to merge 1 commit intoQuantConnect:masterfrom
aiSynergy37 wants to merge 1 commit intoQuantConnect:masterfrom
Conversation
aiSynergy37
changed the title
aiSynergy37
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Add warm-up period support to
RelativeDailyVolume.Why: RDV did not expose
IIndicatorWarmUpPeriodProvider, so consumers could not warm it up consistently through the standard indicator warm-up path.How: Implemented
IIndicatorWarmUpPeriodProvider, added configurableWarmUpPeriod, and defaulted it toperiod + 1to account for the first day initialization sample.Edge cases handled: User overrides of
WarmUpPeriodare preserved; the existing readiness behavior remains based on completed daily samples.Tests added/updated: Added
RelativeDailyVolumeTests.ProvidesConfigurableWarmUpPeriod. Build validation completed forIndicators/QuantConnect.Indicators.csprojandTests/QuantConnect.Tests.csproj; focused local test execution was blocked by the existing pythonnet GIL finalizer crash.